This repository was archived by the owner on Jun 11, 2025. It is now read-only.
feat: add chain ID to handles #474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can ignore most of the lines as they are due to fmt. Only look at the handle changes (3-4 lines). Reminds me we need to enforce fmt and clippy once we are done. |
Add a 64 bit chain ID unsigned value (in big endian) to the handle, making the handle format the following, in order from first to last byte: * 21 bytes from hashing the ciphertext * 1 byte index * 8 bytes of chain ID * 1 byte of ciphertext type * 1 byte of version Resolves: #436 Implementation taken from the following PR from @goshawk-3: https://github.com/zama-ai/httpz-backend/pull/458/files# Changing the chain ID type from i32 to u64 throughout the codebase will be done in a separate commit.
dartdart26
force-pushed
the
petar/chain-id-in-handle
branch
from
029898c to
7f7a502
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a 64 bit chain ID unsigned value (in big endian) to the handle, making the handle format the following, in order from first to last byte:
Resolves: #436
Implementation taken from the following PR from @goshawk-3: https://github.com/zama-ai/httpz-backend/pull/458/files#
Changing the chain ID type from i32 to u64 throughout the codebase will be done in a separate commit.