This repository was archived by the owner on Jun 11, 2025. It is now read-only.
Rudy/feat/handle bytes32 #465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudy-6-4
force-pushed
the
rudy/feat/handle-bytes32
branch
from
dfaa143 to
b20564d
Compare
rudy-6-4
commented
Apr 7, 2025
| @@ -1,168 +1,255 @@ | |||
| // SPDX-License-Identifier: BSD-3-Clause-Clear | |||
| pragma solidity ^0.8.24; | |||
|
|
|||
| enum FheType { | |||
There was a problem hiding this comment.
See if it could be imported by tweaking build.rs
rudy-6-4
commented
Apr 7, 2025
| event FheMax(address indexed caller, uint256 lhs, uint256 rhs, bytes1 scalarByte, uint256 result); | ||
| event FheNeg(address indexed caller, uint256 ct, uint256 result); | ||
| event FheNot(address indexed caller, uint256 ct, uint256 result); | ||
| event FheAdd(address indexed caller, bytes32 lhs, bytes32 rhs, bytes1 scalarByte, bytes32 result); |
There was a problem hiding this comment.
Same. Isolate events in real contract and import
rudy-6-4
force-pushed
the
rudy/feat/handle-bytes32
branch
from
b20564d to
91ac1bb
Compare
dartdart26
approved these changes
Apr 7, 2025
rudy-6-4
force-pushed
the
rudy/feat/handle-bytes32
branch
from
91ac1bb to
89998fa
Compare
|
I have removed "disabling build.rs in release mode" since the test are run in release mode. |
rudy-6-4
force-pushed
the
rudy/feat/handle-bytes32
branch
from
470d704 to
9f669a2
Compare
rudy-6-4
force-pushed
the
rudy/feat/handle-bytes32
branch
from
59b9163 to
622db5d
Compare
rudy-6-4
force-pushed
the
rudy/feat/handle-bytes32
branch
from
622db5d to
35f4fd4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.