This repository was archived by the owner on Jun 11, 2025. It is now read-only.
feat: new deployment super task with env vars names aligned on gateway #455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jatZama
requested review from
eudelins-zama,
tawadaa,
RomanBredehoft and
PacificYield
jatZama
force-pushed
the
deploymentSuperTask
branch
from
24a4a0a to
f73f889
Compare
There was a problem hiding this comment.
LGTM but let's just wait for @0xawaz opinion regarding the dockerfile issue
PacificYield
reviewed
Apr 4, 2025
PacificYield
reviewed
Apr 4, 2025
PacificYield
reviewed
Apr 4, 2025
PacificYield
reviewed
Apr 4, 2025
PacificYield
previously requested changes
Apr 4, 2025
tawadaa
approved these changes
Apr 4, 2025
jatZama
force-pushed
the
deploymentSuperTask
branch
from
9b6fee7 to
50c54c2
Compare
tawadaa
approved these changes
Apr 4, 2025
chore: update dockerfiles chore: refactor checkIsHardhatSigner chore(deploy): fix env file loading chore(deploy): fix prettier fix(ci): remove unnecessary checkout tokens in GPU CI, which are broken since update of repo secrets
jatZama
force-pushed
the
deploymentSuperTask
branch
from
92e33f0 to
bd8403a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.