Skip to content
This repository was archived by the owner on Jun 11, 2025. It is now read-only.

fix(txn-sender): use a WS provider instead of HTTP #449

Merged
merged 1 commit into from
Apr 3, 2025

Conversation

dartdart26
Copy link
Collaborator

Since txn-sender waits for txn receipts, it is better to use WS instead of HTTP and polling. This also makes it faster to get the receipts.

Resolves #443

@dartdart26 dartdart26 self-assigned this Apr 2, 2025
@dartdart26 dartdart26 requested a review from a team as a code owner April 2, 2025 14:06
@cla-bot cla-bot bot added the cla-signed label Apr 2, 2025
@dartdart26 dartdart26 force-pushed the petar/websocket-in-txn-sender branch 3 times, most recently from 5b7d5f0 to a16ecfc Compare April 2, 2025 14:21
Copy link
Contributor

@goshawk-3 goshawk-3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dartdart26 dartdart26 force-pushed the petar/websocket-in-txn-sender branch 3 times, most recently from 036db3d to 2f547c0 Compare April 3, 2025 10:18
Since txn-sender waits for txn receipts, it is better to use WS instead
of HTTP and polling. This also makes it faster to get the receipts.

Resolves #443
@dartdart26 dartdart26 force-pushed the petar/websocket-in-txn-sender branch from 2f547c0 to ed8e6ee Compare April 3, 2025 10:25
@dartdart26 dartdart26 merged commit 4a61a18 into main Apr 3, 2025
11 checks passed
@dartdart26 dartdart26 deleted the petar/websocket-in-txn-sender branch April 3, 2025 11:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(txn-sender): use ws instead of http for the provider
3 participants