This repository was archived by the owner on Jun 11, 2025. It is now read-only.
feat: new events for TFHEExecutor and ACL #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fd0r
approved these changes
Jan 22, 2025
chore: prettier test: forge test new event
fd0r
approved these changes
Jan 22, 2025
This was referenced Jan 22, 2025
jatZama
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is implementing what is asked in issues #254 and #255.
TFHEExecutorWithEventsis renamedTFHEExecutor, meaning the version with events is the default one now.TFHEExecutoris renamedTFHEExecutorNoEventscalleraddress indexed argument (equal tomsg.senderto let ZWS track easily the dApps usage) in all events and adapted mocked mode and thegetFHEGasFromTxReceiptutils function accordingly.HARDHAT_TFHEEXECUTOR_EVENTSas well as all code related to legacy mocked mode which was relying on tracing all non reverting sub-calls, since nowTFHEExecutoremits events by default.allowandallowForDecryptioninACLcontract.