-
Notifications
You must be signed in to change notification settings - Fork 152
feat: adjust date time property conventions rule (#1536) #1536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkrop
added a commit
that referenced
this pull request
Jul 3, 2025
Signed-off-by: Tronje Krop <tronje.krop@jactors.de>
SmilyOrg
reviewed
Jul 4, 2025
tkrop
added a commit
that referenced
this pull request
Jul 4, 2025
Signed-off-by: Tronje Krop <tronje.krop@jactors.de>
tkrop
added a commit
that referenced
this pull request
Jul 4, 2025
Signed-off-by: Tronje Krop <tronje.krop@jactors.de>
👍 |
tkrop
added a commit
that referenced
this pull request
Jul 4, 2025
Signed-off-by: Tronje Krop <tronje.krop@jactors.de>
tkrop
added a commit
that referenced
this pull request
Jul 4, 2025
Signed-off-by: Tronje Krop <tronje.krop@jactors.de>
tkrop
added a commit
that referenced
this pull request
Jul 4, 2025
Signed-off-by: Tronje Krop <tronje.krop@jactors.de>
Signed-off-by: Tronje Krop <tronje.krop@jactors.de>
SmilyOrg
approved these changes
Jul 4, 2025
...et-zalando/src/main/kotlin/org/zalando/zally/ruleset/zalando/DateTimePropertiesSuffixRule.kt
Outdated
Show resolved
Hide resolved
ePaul
reviewed
Jul 4, 2025
...alando/src/test/kotlin/org/zalando/zally/ruleset/zalando/DateTimePropertiesSuffixRuleTest.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Miha Lunar <mlunar@gmail.com> Co-authored-by: Paŭlo Ebermann <paul.ebermann@zalando.de>
👍 |
1 similar comment
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
minor
Minor changes, e.g. low risk config updates, changes that do not introduce a new API call.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adjusts the date time property suffix rule according to the rule change conducted in zalando/restful-api-guidelines#811.
fixes #1501.