Skip to content

Skip major upgrade for standby clusters with warning #2775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Skip major upgrade for standby clusters with warning #2775

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b9ffc2
Skip major upgrade for standby clusters with warning
hughcapet Oct 15, 2024
4c79f9f
Check when no master in the cluster as well
hughcapet Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions pkg/cluster/majorversionupgrade.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,11 @@ func (c *Cluster) majorVersionUpgrade() error {
for i, pod := range pods {
ps, _ := c.patroni.GetMemberData(&pod)

if ps.Role == "standby_leader" {
c.logger.Errorf("skipping major version upgrade for %s/%s standby cluster. Re-deploy standby cluster with the required Postgres version specified", c.Namespace, c.Name)
return nil
}

if ps.State != "running" {
allRunning = false
c.logger.Infof("identified non running pod, potentially skipping major version upgrade")
Expand All @@ -156,6 +161,11 @@ func (c *Cluster) majorVersionUpgrade() error {
}
}

if masterPod == nil {
c.logger.Infof("no master in the cluster, skipping major version upgrade")
return nil
}

// Recheck version with newest data from Patroni
if c.currentMajorVersion >= desiredVersion {
if _, exists := c.ObjectMeta.Annotations[majorVersionUpgradeFailureAnnotation]; exists { // if failure annotation exists, remove it
Expand Down
Loading