relax validation pattern for logicalBackupSchedule #1993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will allow to immediately discard invalid values when parsing a logicalBackupSchedule string.
Previously used regular expression '^(\d+|\*)(/\d+)?(\s+(\d+|\*)(/\d+)?){4}$' may pass invalid values to cron, like "00 03 * * 7"
Although "00 03 * * 7" may be valid on some systems, but this value will throw an error when applied to kubernetes.
https://en.wikipedia.org/wiki/Cron
FYI: kubernetes uses cron implementation from go module "github.com/robfig/cron/v3"
https://github.com/robfig/cron/blob/v3/spec.go
https://github.com/robfig/cron/blob/v3/parser.go
hornwind
requested review from
CyberDem0n,
FxKu,
Jan-M,
idanovinda,
jopadi and
sdudoladov
as code owners
FxKu
changed the title
|
In my view this validation should just be removed, as it will fail many valid schedule strings using intervals, named days, ranges, etc. and it would be nearly impossible to properly validate them. See #2323. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will allow to immediately discard invalid values when parsing a logicalBackupSchedule string.
Previously used regular expression
^(\d+|\*)(/\d+)?(\s+(\d+|\*)(/\d+)?){4}$may pass invalid values to cron, like"00 03 * * 7"Although
"00 03 * * 7"may be valid on some systems, but this value will throw an error when applied to kubernetes.https://en.wikipedia.org/wiki/Cron
FYI: kubernetes uses cron implementation from go module "github.com/robfig/cron/v3"
https://github.com/robfig/cron/blob/v3/spec.go
https://github.com/robfig/cron/blob/v3/parser.go