-
-
Notifications
You must be signed in to change notification settings - Fork 28
feat: get artist singles #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zokiasu
wants to merge
20
commits into
zS1L3NT:main
Choose a base branch
from
zokiasu:feature/get-artist-singles
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feature/get-artist-singles
I see your branch has more commits, would you like me to incorporate more of those changes into the PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add getArtistSingles function
Description
This PR adds a new
getArtistSingles
function to retrieve the complete list of singles from an artist. While the existinggetArtist
function only returns top singles, this new function fetches all singles available on the artist's page, similar to howgetArtistAlbums
works for albums.Features
getArtistSingles
function that returns an array ofAlbumDetailed
getArtistAlbums
Implementation Details
getArtistAlbums
for consistencyAlbumParser.parseArtistAlbum
for parsing the responseTesting
core.spec.ts
Use Case
This function is particularly useful when you need to:
Example Usage