Skip to content

👷 ci: install all extras in ci #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 21, 2025
Merged

👷 ci: install all extras in ci #573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3d61ae
👷 ci: install all extras in ci
SigureMo Sep 21, 2025
a600967
use ci-install
SigureMo Sep 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint-and-fmt.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:

- name: Install dependencies
run: |
just ci-install-all ${{ matrix.python-version }}
just ci-install ${{ matrix.python-version }}

- name: lint
run: |
Expand Down
5 changes: 0 additions & 5 deletions justfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,7 @@ generate-schema:
uv run scripts/generate-schema.py

# CI specific
# TODO(SigureMo): Install all extra when cryptography support 3.14t.
# See https://github.com/pyca/cryptography/issues/12489#issuecomment-3133415491 for more details.
ci-install pyversion:
Copy link

Copilot AI Sep 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The prior explanatory TODO about waiting for cryptography support was removed without replacement, losing useful context for why this consolidation is now safe. Consider adding a brief comment (e.g., 'All extras enabled now that cryptography supports required Python version — see <issue/link>') to preserve traceability.

Suggested change
ci-install pyversion:
ci-install pyversion:
# All extras enabled now that cryptography supports required Python version — see https://github.com/siguremo/yutto/issues/123

Copilot uses AI. Check for mistakes.
uv sync --dev -p {{pyversion}}

ci-install-all pyversion:
uv sync --all-extras --dev -p {{pyversion}}

Copy link

Copilot AI Sep 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The behavior of ci-install has changed (now installs all extras) and the previous ci-install-all target was removed. This is a breaking interface change for any external workflows or documentation referencing ci-install-all or expecting ci-install to be a lighter install. Consider retaining ci-install-all as a backward-compatible alias (even temporarily) or adding a deprecation notice to ease transition.

Suggested change
ci-install-all pyversion:
@echo "Warning: 'ci-install-all' is deprecated and will be removed in a future release. Please use 'ci-install' instead."
just ci-install {{pyversion}}

Copilot uses AI. Check for mistakes.
ci-fmt-check:
Expand Down
Loading
Loading