👷 ci: unpin nodejs version #571
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes the pinned Node.js version from CI workflows to allow for more flexible version management. The change aligns with the CI category indicated in the PR description and removes explicit version constraints that may have been causing compatibility or maintenance issues.
- Unpins Node.js version specification from GitHub Actions workflows
- Maintains pnpm caching configuration while removing version constraints
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/vitepress-deploy.yml | Removes pinned Node.js version "22" from VitePress deployment workflow |
| .github/workflows/lint-and-fmt.yml | Removes pinned Node.js version "22" from linting and formatting workflow |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v5 | ||
| with: |
There was a problem hiding this comment.
Removing the node-version specification will cause the workflow to use the default Node.js version provided by the runner, which may change unexpectedly and cause build inconsistencies. Consider specifying a version range (e.g., '>=18') or using a .nvmrc file to maintain predictable builds while allowing flexibility.
| with: | |
| with: | |
| node-version: '>=18' |
|
|
||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v5 | ||
| with: |
There was a problem hiding this comment.
Removing the node-version specification will cause the workflow to use the default Node.js version provided by the runner, which may change unexpectedly and cause build inconsistencies. Consider specifying a version range (e.g., '>=18') or using a .nvmrc file to maintain predictable builds while allowing flexibility.
| with: | |
| with: | |
| node-version: '>=18' |
CodSpeed Performance ReportMerging #571 will not alter performanceComparing Summary
|
动机
解决方案
类型