⚡️ perf(biliass): improve biliass performance #547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…better performance
…ngle string instead of a vector
…timize performance
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the biliass performance by replacing the cached crate with a custom cache implementation and applying various micro-optimizations throughout the codebase.
- Implements a custom
ZoomFactorCacheusingFxHashMapandOnceLockto replace thecachedproc macro - Optimizes string handling in XML parsing by using direct string concatenation instead of collecting vectors
- Applies performance optimizations including inlining, parallel filtering, and unstable sorting
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/biliass/rust/src/writer/utils.rs | Replaces cached proc macro with custom zoom factor cache implementation |
| packages/biliass/rust/src/reader/xml.rs | Optimizes string concatenation in comment content parsing |
| packages/biliass/rust/src/reader/utils.rs | Adds inline attribute to unescape_newline function |
| packages/biliass/rust/src/filter.rs | Optimizes position matching with direct pattern matching and inline attribute |
| packages/biliass/rust/src/convert.rs | Multiple optimizations including parallel filtering, unstable sorting, and string handling |
| packages/biliass/rust/Cargo.toml | Updates dependencies and compiler optimization settings |
CodSpeed Performance ReportMerging #547 will improve performances by 24.91%Comparing Summary
Benchmarks breakdown
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
动机
利用 copilot 优化 biliass 性能
解决方案
交给 @copilot
类型