Skip to content

Conversation

@SigureMo
Copy link
Member

@SigureMo SigureMo commented Aug 4, 2025

动机

#545 (comment)

Python 3.13t 支持无法说得上完善,单测执行起来相比于其他版本慢非常多(其他版本 20s 左右,3.13t 5min),因此继续支持 3.13t 没有意义,本 PR drop 3.13t 支持,仅保留 3.14t 支持

解决方案

类型

  • ✨ feat: 添加新功能
  • 🐛 fix: 修复 bug
  • 📝 docs: 对文档进行修改
  • ♻️ refactor: 代码重构(既不是新增功能,也不是修改 bug 的代码变动)
  • ⚡ perf: 提高性能的代码修改
  • 🧑‍💻 dx: 优化开发体验
  • 🔨 workflow: 工作流变动
  • 🏷️ types: 类型声明修改
  • 🚧 wip: 工作正在进行中
  • ✅ test: 测试用例添加及修改
  • 🔨 build: 影响构建系统或外部依赖关系的更改
  • 👷 ci: 更改 CI 配置文件和脚本
  • ❓ chore: 其它不涉及源码以及测试的修改
  • ⬆️ deps: 依赖项修改
  • 🔖 release: 发布新版本

Copilot AI review requested due to automatic review settings August 4, 2025 17:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes Python 3.13t support from CI workflows while retaining 3.14t support, addressing performance issues where Python 3.13t tests were taking significantly longer to run (5 minutes vs 20 seconds for other versions).

  • Remove Python 3.13t from all test matrices across CI workflows
  • Update build configurations to exclude Python 3.13t from binary distribution
  • Simplify Windows build workflow by using a single Python version (3.14t)

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
.github/workflows/unit-test.yml Remove 3.13t from test matrix
.github/workflows/latest-release-test.yml Remove 3.13t from test matrix
.github/workflows/e2e-test.yml Remove 3.13t from test matrix
.github/workflows/biliass-build-and-release.yml Remove 3.13t from build interpreters and simplify Windows build
Comments suppressed due to low confidence (1)

.github/workflows/biliass-build-and-release.yml:143

  • Python 3.14t is a pre-release version that may not be stable or available in all environments. Consider using a stable Python version for production builds unless specifically required for testing.
          python-version: "3.14t"

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 4, 2025

CodSpeed Performance Report

Merging #546 will not alter performance

Comparing drop-py313t (1e480f1) with main (4ddbe8b)

Summary

✅ 30 untouched benchmarks

@SigureMo SigureMo merged commit fc68a22 into main Aug 4, 2025
39 checks passed
@SigureMo SigureMo deleted the drop-py313t branch August 4, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants