-
-
Notifications
You must be signed in to change notification settings - Fork 130
✨ feat(biliass): support python 3.14 #531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds support for Python 3.14 by updating Rust and Python metadata and CI workflows
- Bump several Rust dependency versions to their latest patch releases
- Add Python 3.14 classifier to
pyproject.toml - Extend GitHub Actions to build for Python 3.14 interpreters
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/biliass/rust/Cargo.toml | Updated several dependency patch versions |
| packages/biliass/pyproject.toml | Added "Programming Language :: Python :: 3.14" |
| .github/workflows/biliass-build-and-release.yml | Extended --interpreter args and matrix for Python 3.14 |
Comments suppressed due to low confidence (4)
.github/workflows/biliass-build-and-release.yml:53
- This change removes the plain
3.13interpreter from the build matrix, so CPython 3.13 wheels will no longer be generated. Consider including3.13alongside the other interpreters (e.g.,'3.13 3.13t 3.14 3.14t').
args: --release --out dist --interpreter '3.14 3.13t 3.14t'
.github/workflows/biliass-build-and-release.yml:85
- The plain
3.13interpreter is missing here, so CPython 3.13 wheels won’t be built for this job. You may want to revert to--interpreter '3.13 3.13t 3.14 3.14t'to cover both versions.
args: --release --out dist --interpreter '3.14 3.13t 3.14t'
.github/workflows/biliass-build-and-release.yml:176
- CPython 3.13 is no longer included in this interpreter list, so builds for 3.13 will be skipped. Restore
3.13in the list ('3.13 3.13t 3.14 3.14t') if support for existing wheels should be maintained.
args: --release --out dist --interpreter '3.14 3.13t 3.14t'
.github/workflows/biliass-build-and-release.yml:136
python-versionsis indented under a matrix entry, but it should be a top-level axis understrategy.matrix. Moving it to the same level asplatformensures the matrix expands correctly.
python-versions:
CodSpeed Performance ReportMerging #531 will not alter performanceComparing Summary
|
动机
biliass 支持 Python 3.14(含 free-threading)
解决方案
现在每个平台需要编译 abi3、cp313t、cp314t 三个 wheel 包(PEP 779 说好的 3.14 只有一个 abi 呢?也许后续会有改进吧?)
yutto 还不支持 3.14,需要等 pydantic 支持后才能支持
类型