Skip to content

Conversation

@SigureMo
Copy link
Member

@SigureMo SigureMo commented Jul 8, 2025

动机

biliass 支持 Python 3.14(含 free-threading)

解决方案

现在每个平台需要编译 abi3、cp313t、cp314t 三个 wheel 包(PEP 779 说好的 3.14 只有一个 abi 呢?也许后续会有改进吧?)

yutto 还不支持 3.14,需要等 pydantic 支持后才能支持

类型

  • ✨ feat: 添加新功能
  • 🐛 fix: 修复 bug
  • 📝 docs: 对文档进行修改
  • ♻️ refactor: 代码重构(既不是新增功能,也不是修改 bug 的代码变动)
  • ⚡ perf: 提高性能的代码修改
  • 🧑‍💻 dx: 优化开发体验
  • 🔨 workflow: 工作流变动
  • 🏷️ types: 类型声明修改
  • 🚧 wip: 工作正在进行中
  • ✅ test: 测试用例添加及修改
  • 🔨 build: 影响构建系统或外部依赖关系的更改
  • 👷 ci: 更改 CI 配置文件和脚本
  • ❓ chore: 其它不涉及源码以及测试的修改
  • ⬆️ deps: 依赖项修改
  • 🔖 release: 发布新版本

Copilot AI review requested due to automatic review settings July 8, 2025 15:39

This comment was marked as outdated.

@SigureMo SigureMo requested a review from Copilot July 8, 2025 15:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds support for Python 3.14 by updating Rust and Python metadata and CI workflows

  • Bump several Rust dependency versions to their latest patch releases
  • Add Python 3.14 classifier to pyproject.toml
  • Extend GitHub Actions to build for Python 3.14 interpreters

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
packages/biliass/rust/Cargo.toml Updated several dependency patch versions
packages/biliass/pyproject.toml Added "Programming Language :: Python :: 3.14"
.github/workflows/biliass-build-and-release.yml Extended --interpreter args and matrix for Python 3.14
Comments suppressed due to low confidence (4)

.github/workflows/biliass-build-and-release.yml:53

  • This change removes the plain 3.13 interpreter from the build matrix, so CPython 3.13 wheels will no longer be generated. Consider including 3.13 alongside the other interpreters (e.g., '3.13 3.13t 3.14 3.14t').
          args: --release --out dist --interpreter '3.14 3.13t 3.14t'

.github/workflows/biliass-build-and-release.yml:85

  • The plain 3.13 interpreter is missing here, so CPython 3.13 wheels won’t be built for this job. You may want to revert to --interpreter '3.13 3.13t 3.14 3.14t' to cover both versions.
          args: --release --out dist --interpreter '3.14 3.13t 3.14t'

.github/workflows/biliass-build-and-release.yml:176

  • CPython 3.13 is no longer included in this interpreter list, so builds for 3.13 will be skipped. Restore 3.13 in the list ('3.13 3.13t 3.14 3.14t') if support for existing wheels should be maintained.
          args: --release --out dist --interpreter '3.14 3.13t 3.14t'

.github/workflows/biliass-build-and-release.yml:136

  • python-versions is indented under a matrix entry, but it should be a top-level axis under strategy.matrix. Moving it to the same level as platform ensures the matrix expands correctly.
        python-versions:

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 8, 2025

CodSpeed Performance Report

Merging #531 will not alter performance

Comparing biliass/support-py314 (6708c1f) with main (5528430)

Summary

✅ 30 untouched benchmarks

@SigureMo SigureMo changed the title ✨ feat: support python 3.14 ✨ feat(biliass): support python 3.14 Jul 8, 2025
@SigureMo SigureMo merged commit 8c14c12 into main Jul 8, 2025
39 checks passed
@SigureMo SigureMo deleted the biliass/support-py314 branch July 8, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants