♻️ refactor: use rust binding Comment struct
#311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SigureMo
changed the title
Comment struct
This was referenced Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
动机
biliass rustify 计划
biliass(replaceprotobufdep with rust binding) #306filter_bad_chars#309Commentstruct #311解决方案
本 PR 使用 bind 的 Comment 替换 NamedTuple Comment，以便后续重构，本 PR 会引起部分性能回归（20s -> 46s），相比于不可变对象 tuple，bind 的对象有一部分转换开销，特别是访问属性时，但后续完全移到 rust 后会消除这一部分开销
类型