Skip to content

[Docs] Dynamic Font Awesome Loading (Free Default, Pro Conditional) #28043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jul 25, 2025

Conversation

samiahmedsiddiqui
Copy link
Contributor

@samiahmedsiddiqui samiahmedsiddiqui commented Jul 21, 2025

This pull request updates our npm scripts and build process to dynamically load Font Awesome icons. The primary goal is to default to Font Awesome Free for all users, ensuring most icons are available without requiring a specific license.

For environments where a Font Awesome Pro key is available and configured, the scripts will conditionally load Font Awesome Pro. This approach allows us to:

  • Maximize icon availability: Most users will benefit from the extensive Font Awesome Free library.
  • Secure Font Awesome Pro key: The Pro key is only utilized when explicitly provided, preventing its exposure in environments where it's not needed.
  • Improve build flexibility: The build process adapts automatically based on the presence of the Pro key, streamlining development and deployment for different license requirements.

This change ensures a robust and secure method for handling Font Awesome across our project.

@samiahmedsiddiqui samiahmedsiddiqui changed the title Removing .npmrc file and securing FontAwesome authtoken as environment variable [Docs] Removing .npmrc file and securing FontAwesome authtoken as environment variable Jul 23, 2025
Copy link

netlify bot commented Jul 23, 2025

Deploy Preview for infallible-bardeen-164bc9 ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/projects/infallible-bardeen-164bc9/deploys/688231dd6e37188f4d71128b
😎 Deploy Preview https://deploy-preview-28043--infallible-bardeen-164bc9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@samiahmedsiddiqui samiahmedsiddiqui changed the title [Docs] Removing .npmrc file and securing FontAwesome authtoken as environment variable [Docs] Dynamic Font Awesome Loading (Free Default, Pro Conditional) Jul 23, 2025
@ddhodge ddhodge added the area/documentation Documentation needed label Jul 23, 2025
@ddhodge ddhodge self-assigned this Jul 24, 2025
@github-project-automation github-project-automation bot moved this to In progress in Documentation Jul 24, 2025
Copy link
Contributor

@ddhodge ddhodge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ddhodge ddhodge merged commit abddd67 into yugabyte:master Jul 25, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Documentation Jul 25, 2025
@samiahmedsiddiqui samiahmedsiddiqui deleted the secure-fontawesome-key branch July 25, 2025 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Documentation needed
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants