-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[Docs] Dynamic Font Awesome Loading (Free Default, Pro Conditional) #28043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ddhodge
merged 17 commits into
yugabyte:master
from
samiahmedsiddiqui:secure-fontawesome-key
Jul 25, 2025
Merged
[Docs] Dynamic Font Awesome Loading (Free Default, Pro Conditional) #28043
ddhodge
merged 17 commits into
yugabyte:master
from
samiahmedsiddiqui:secure-fontawesome-key
Jul 25, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for infallible-bardeen-164bc9 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ddhodge
approved these changes
Jul 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates our npm scripts and build process to dynamically load Font Awesome icons. The primary goal is to default to Font Awesome Free for all users, ensuring most icons are available without requiring a specific license.
For environments where a Font Awesome Pro key is available and configured, the scripts will conditionally load Font Awesome Pro. This approach allows us to:
This change ensures a robust and secure method for handling Font Awesome across our project.