Skip to content

Conversation

@neutrinoceros
Copy link
Member

PR Summary

xref: numpy/numpy#29536

This is incomplete at the time of opening, I just want to take what I already have for a spin on CI

PR Checklist

  • New features are documented, with docstrings and narrative docs
  • Adds a test for any bugs fixed. Adds tests for new features.

@neutrinoceros neutrinoceros added this to the 4.4.2 milestone Oct 19, 2025
@neutrinoceros neutrinoceros added bug refactor improve readability, maintainability, modularity labels Oct 19, 2025
@neutrinoceros neutrinoceros force-pushed the compat/numpy_shapes branch 5 times, most recently from 35d1bbf to 569c545 Compare October 19, 2025 17:26
@matthewturk
Copy link
Member

Your work on making this backward- and forward-compatible is admirable, and I wish it didn't have to be so.

@neutrinoceros
Copy link
Member Author

yeah it's a bit fiddly. Hopefully it should be straightforward to find-and-replace when the time comes.

@matthewturk
Copy link
Member

What I was trying to say without saying it is that I wish we didn't have to make this change, and I agree it looks a bit fiddly to use the COPY object etc, but I guess we have to because of upstream changes. So, thank you.

@neutrinoceros
Copy link
Member Author

Oh yeah, this has been on my radar for a while but I was constantly putting it off, but it seems to be moving forward upstream...

@neutrinoceros
Copy link
Member Author

Clearly I messed up somewhere. Help is welcome, but in the meantime, I'll be off duty for today.

@neutrinoceros neutrinoceros marked this pull request as ready for review October 19, 2025 22:33
@neutrinoceros
Copy link
Member Author

ok this is now reasonably stable, so, opening for review.
Note that I avoided dealing with yt/volume_rendering to save whatever little time, but this needs to be done too (preferably by someone else, that I can then review).

@neutrinoceros neutrinoceros changed the title BUG: avoid soon-to-be-deprecated direct mutations of ndarray.shape attributes BUG: avoid soon-to-be-deprecated direct mutations of ndarray.shape attributes (1/2) Oct 20, 2025
@neutrinoceros
Copy link
Member Author

... I couldn't resist. Volume Rendering is now handled in its own PR to hopefully make reviewing swifter. See #5309

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug refactor improve readability, maintainability, modularity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants