BLD/RFC: cleanup limited_api build logic #5288
Draft
+16
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
added
refactor
neutrinoceros
changed the title
|
this doesn't work out of the box because distutils is very fragile, but it's also easily fixed, so I'll try to fix it upstream. |
|
upstream fix is at: pypa/setuptools#5084 |
neutrinoceros
force-pushed
the
bld/rfc/cleanup-bdist-wheel
branch
from
1691165 to
512781a
Compare
neutrinoceros
changed the title
|
This is now ready for review. |
|
ah crap, I forgot this was actually waiting for a fix upstream. Nevermind then. Sorry about the noise guys :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Builds off #5287, but this part is (very) slightly more risky (removing 10 y.o. workarounds) so I don't want to backport it to a bugfix release.
PR Checklist