Remove unnecessary instances of ds.index #5277
Open
+1
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brittonsmith
added
tests: running tests
|
I don't think any of the affected test cases are currently covered by CI, with the outage we've been having, so it might be a little risky to merge now |
cphyc
approved these changes
Sep 2, 2025
There was a problem hiding this comment.
This looks good to me, although I agree with @neutrinoceros that this isn't covered by CI as far as I could tell. I'm happy to sit on it until we have a working CI again, since this isn't critical.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses Issue #5275. After PR #5250, we no longer need to access
ds.indexto createds.field_info. This removes some calls added in PR #5211 as well as a few other places that were very obviously the same. I stayed away from modifying any source code, other than one helper function. I was also able to eliminate a place in the docs that mentions having to dods.indexbefore accessingds.field_info.