baroclinic vorticity typo fix in yt/fields/fluid_vector_fields.py #5270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Their was small typo in the code to calculate the x component on the baroclinic vorticity term, just a small switch of z and y component on the density gradient used in the calculation.
|
Hi! Welcome, and thanks for opening this pull request. We have some guidelines for new pull requests, and soon you'll hear back about the results of our tests and continuous integration checks. Thank you for your contribution! |
cphyc
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was small typo in the code to calculate the x component on the baroclinic vorticity term, just a small switch of z and y component on the density gradient used in the calculation.
PR Summary
There was small typo in the function to calculate the baroclinic_vorticity_x term. It used the z component of the density gradient rather than the y component of the density gradient. The change I made was simply deleting the z for a y.
Should be a 1 character change.
PR Checklist
I did not do any testing, just a bug I noticed by eye.