Change VersionVector actorID encoding from hex to base64 #1030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To reduce the size of serialized VersionVectors, the actorID encoding format has been changed from hex string to base64. Since actorIDs are used as keys in VersionVector objects and frequently transferred in network messages, reducing their length helps decrease payload size and improve performance. This change does not affect the semantics of the actorID, only its encoded representation.
WalkthroughThe conversion logic for Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Converter
participant Protobuf
Client->>Converter: toVersionVector(versionVector)
Converter->>Converter: Convert actor IDs from hex to Uint8Array
Converter->>Converter: Encode Uint8Array to base64
Converter->>Protobuf: Store base64 as keys in vector map
Protobuf->>Converter: fromVersionVector(protoVector)
Converter->>Converter: Decode base64 keys to Uint8Array
Converter->>Converter: Convert Uint8Array to hex strings
Converter->>Client: Return reconstructed VersionVector
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related issues
Suggested reviewers
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
|
hackerwins
force-pushed
the
main
branch
4 times, most recently
from
3f1f084 to
0d6a2da
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1030 +/- ##
==========================================
- Coverage 78.10% 77.91% -0.19%
==========================================
Files 66 66
Lines 5764 5788 +24
Branches 1043 1049 +6
==========================================
+ Hits 4502 4510 +8
- Misses 951 963 +12
- Partials 311 315 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hackerwins
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
To reduce the size of serialized VersionVectors, the actorID encoding format has been changed from hex string to base64. Since actorIDs are used as keys in VersionVector objects and frequently transferred in network messages, reducing their length helps decrease payload size and improve performance. This change does not affect the semantics of the actorID, only its encoded representation.
Any background context you want to provide?
What are the relevant tickets?
Related to yorkie-team/yorkie#1388
Checklist
Summary by CodeRabbit
Summary by CodeRabbit