Skip to content

Add OffsetPagination::addLinkAttributes() and GridView::filterFormAttributes(). Fix sortableLinkAttributes usage. #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2025

Conversation

vjik
Copy link
Member

@vjik vjik commented Apr 15, 2025

Q A
Is bugfix? ✔️
New feature? ✔️
Breaks BC?

…Attributes()`. Fix `sortableLinkAttributes` usage.
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

Attention: Patch coverage is 38.46154% with 8 lines in your changes missing coverage. Please review.

Project coverage is 86.19%. Comparing base (d2e479b) to head (63f8724).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/GridView.php 50.00% 4 Missing ⚠️
src/Pagination/OffsetPagination.php 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #276      +/-   ##
============================================
- Coverage     86.50%   86.19%   -0.32%     
- Complexity      636      638       +2     
============================================
  Files            50       50              
  Lines          2164     2173       +9     
============================================
+ Hits           1872     1873       +1     
- Misses          292      300       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vjik vjik requested a review from a team April 15, 2025 08:29
@vjik vjik added the status:code review The pull request needs review. label Apr 15, 2025
@vjik vjik merged commit 97ba4f8 into master Apr 16, 2025
20 of 22 checks passed
@vjik vjik deleted the attrs branch April 16, 2025 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants