Skip to content

Add prepend/append options to BaseListView #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 15, 2025
Merged

Add prepend/append options to BaseListView #273

merged 6 commits into from
Apr 15, 2025

Conversation

vjik
Copy link
Member

@vjik vjik commented Apr 11, 2025

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

@vjik vjik requested a review from a team April 11, 2025 09:50
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 85.90%. Comparing base (64814af) to head (972d229).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/BaseListView.php 16.66% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #273      +/-   ##
============================================
- Coverage     86.29%   85.90%   -0.39%     
- Complexity      632      636       +4     
============================================
  Files            50       50              
  Lines          2152     2164      +12     
============================================
+ Hits           1857     1859       +2     
- Misses          295      305      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vjik vjik added the status:code review The pull request needs review. label Apr 11, 2025
@samdark
Copy link
Member

samdark commented Apr 13, 2025

What is the use case? Why not use the template itself?

prepended
<?= GridView::widget() ?>
appended

@vjik
Copy link
Member Author

vjik commented Apr 13, 2025

prepended
<?= GridView::widget() ?>
appended

prepend/append added blocks into container:

<container>
prepend
... body ...
append
</container>

This is convient for configuration. For example, add overlay block that visualizes loading process.

vjik and others added 3 commits April 15, 2025 09:56
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
@vjik vjik merged commit 26689ef into master Apr 15, 2025
20 of 22 checks passed
@vjik vjik deleted the append-prepend branch April 15, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants