Skip to content

Replace GlobalContext by HeaderContext #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 31, 2025
Merged

Replace GlobalContext by HeaderContext #269

merged 3 commits into from
Mar 31, 2025

Conversation

vjik
Copy link
Member

@vjik vjik commented Mar 30, 2025

Q A
Is bugfix?
New feature?
Breaks BC? ✔️

Copy link

codecov bot commented Mar 30, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 83.66%. Comparing base (ddcf11f) to head (a29d9ac).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/Column/Base/GlobalContext.php 85.71% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #269      +/-   ##
============================================
- Coverage     83.74%   83.66%   -0.09%     
+ Complexity      631      629       -2     
============================================
  Files            51       50       -1     
  Lines          2147     2136      -11     
============================================
- Hits           1798     1787      -11     
  Misses          349      349              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vjik vjik requested a review from a team March 30, 2025 15:42
@vjik vjik added the status:code review The pull request needs review. label Mar 30, 2025
@samdark
Copy link
Member

samdark commented Mar 31, 2025

The overall idea is that a common context for the whole widget makes sense in any place, be it footer, header or data cell.

@samdark
Copy link
Member

samdark commented Mar 31, 2025

👍

@vjik vjik merged commit 17bb2ef into master Mar 31, 2025
22 checks passed
@vjik vjik deleted the improve-context branch March 31, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants