Skip to content

More tests #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 13, 2025
Merged

More tests #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e500e15
More tests
samdark Mar 11, 2025
8b819e4
Tests
samdark Mar 11, 2025
d80f193
More
samdark Mar 12, 2025
5306e89
more
samdark Mar 13, 2025
1a51b7c
Fix
samdark Mar 13, 2025
36bf567
Fix
samdark Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions tests/Column/DataColumnTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@
use Yiisoft\Definitions\Exception\InvalidConfigException;
use Yiisoft\Definitions\Exception\NotInstantiableException;
use Yiisoft\Factory\NotFoundException;
use Yiisoft\Validator\Rule\Email;
use Yiisoft\Yii\DataView\Column\DataColumn;
use Yiisoft\Yii\DataView\Filter\Factory\EqualsFilterFactory;
use Yiisoft\Yii\DataView\GridView;
use Yiisoft\Yii\DataView\Tests\Support\Assert;
use Yiisoft\Yii\DataView\Tests\Support\TestTrait;
Expand Down Expand Up @@ -698,7 +700,7 @@ public function testFilterWithValidationError(): void
new DataColumn(
'email',
filter: true,
filterValidation: new \Yiisoft\Validator\Rule\Email()
filterValidation: new Email()
),
)
->id('w1-grid')
Expand Down Expand Up @@ -745,7 +747,7 @@ public function testCustomFilterFactory(): void
new DataColumn(
'status',
filter: true,
filterFactory: new \Yiisoft\Yii\DataView\Filter\Factory\EqualsFilterFactory()
filterFactory: new EqualsFilterFactory()
),
)
->id('w1-grid')
Expand Down
293 changes: 230 additions & 63 deletions tests/Column/RadioColumnRendererTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,53 +241,6 @@ public function testRenderFooterWithContent(): void
$this->assertSame('Footer content', $result->getContent()[0]);
}

public function testRenderFooterWithoutContent(): void
{
$column = new RadioColumn();
$cell = new Cell();
$translator = Mock::translator('en');

$context = new GlobalContext(
dataReader: $this->dataReader,
pathArguments: [],
queryParameters: [],
translator: $translator,
translationCategory: 'test'
);

$renderer = new RadioColumnRenderer();
$result = $renderer->renderFooter($column, $cell, $context);

$this->assertEmpty($result->getContent());
}

public function testRenderBodyWithCustomContentAndEmptyAttributes(): void
{
$column = new RadioColumn(
bodyAttributes: [],
inputAttributes: [],
content: static fn($input) => Html::div($input)->class('custom-wrapper')
);
$cell = new Cell();
$data = ['id' => 1];

$context = new DataContext(
preparedDataReader: $this->dataReader,
column: $column,
data: $data,
key: 1,
index: 0
);

$renderer = new RadioColumnRenderer();
$result = $renderer->renderBody($column, $cell, $context);

$content = $result->getContent();
$this->assertNotEmpty($content);
$this->assertStringContainsString('<div class="custom-wrapper">', (string)$content[0]);
$this->assertEmpty($result->getAttributes());
}

public function testRenderBodyWithCustomName(): void
{
$column = new RadioColumn(
Expand Down Expand Up @@ -648,12 +601,9 @@ public function testRenderBodyWithCustomHtmlContent(): void
content: static fn($input) => Html::div()
->class('input-group')
->content(
Html::label()
->content(
$input,
Html::span('*')->class('required'),
'Select user'
)
$input,
Html::span('*')->class('required'),
'Select user'
)
);
$cell = new Cell();
Expand Down Expand Up @@ -811,7 +761,6 @@ public function testRenderBodyWithCustomContent(): void

public function testDefaultNameIsUsedWhenNotProvided(): void
{
// Arrange
$column = new RadioColumn();
$cell = new Cell();
$data = ['id' => 42];
Expand All @@ -824,10 +773,8 @@ public function testDefaultNameIsUsedWhenNotProvided(): void
);
$renderer = new RadioColumnRenderer();

// Act
$result = $renderer->renderBody($column, $cell, $context);

// Assert
$content = $result->getContent();
$this->assertStringContainsString('name="radio-selection"', (string)$content[0]);
}
Expand Down Expand Up @@ -892,7 +839,7 @@ public function testRenderBodyWithEmptyContentClosure(): void
public function testRenderBodyWithContextInContentClosure(): void
{
$column = new RadioColumn(
content: static fn($input, $context) => (string)$input . ' Item ' . $context->index
content: static fn($input, $context) => $input . ' Item ' . $context->index
);
$cell = new Cell();
$data = ['id' => 42];
Expand Down Expand Up @@ -1115,7 +1062,6 @@ public function testRenderBodyWithCustomValueAndChecked(): void

public function testEmptyNameAttributeIsPreserved(): void
{
// Arrange
$column = new RadioColumn(
inputAttributes: [
'name' => '',
Expand All @@ -1135,17 +1081,14 @@ public function testEmptyNameAttributeIsPreserved(): void
);
$renderer = new RadioColumnRenderer();

// Act
$result = $renderer->renderBody($column, $cell, $context);

// Assert
$content = $result->getContent();
$this->assertStringContainsString('name value="1"', (string)$content[0]);
}

public function testEmptyValueAttributeIsPreserved(): void
{
// Arrange
$column = new RadioColumn(
inputAttributes: [
'value' => '',
Expand All @@ -1165,10 +1108,8 @@ public function testEmptyValueAttributeIsPreserved(): void
);
$renderer = new RadioColumnRenderer();

// Act
$result = $renderer->renderBody($column, $cell, $context);

// Assert
$content = $result->getContent();
$this->assertStringContainsString('name="radio-selection" value', (string)$content[0]);
}
Expand Down Expand Up @@ -1253,4 +1194,230 @@ public function testRenderBodyWithInactiveStatus(): void
$this->assertStringNotContainsString('checked', (string)$content[0]);
$this->assertFalse($result->shouldEncode());
}

public function testContentClosureReceivesInputAndContext(): void
{
$expectedInput = null;
$expectedContext = null;
$column = new RadioColumn(
inputAttributes: [
'class' => 'form-check-input',
'name' => 'selection',
],
content: static function($input, $context) use (&$expectedInput, &$expectedContext) {
$expectedInput = $input;
$expectedContext = $context;
return $input;
}
);
$cell = new Cell();
$data = ['id' => 42, 'name' => 'Test'];
$context = new DataContext(
preparedDataReader: $this->dataReader,
column: $column,
data: $data,
key: 1,
index: 0
);
$renderer = new RadioColumnRenderer();

$result = $renderer->renderBody($column, $cell, $context);

$this->assertNotNull($expectedInput);
$this->assertStringContainsString('type="radio"', (string)$expectedInput);
$this->assertSame($context, $expectedContext);
}

public function testContentClosureCanModifyInput(): void
{
$column = new RadioColumn(
inputAttributes: [
'class' => 'form-check-input',
'name' => 'selection',
],
content: static function($input) {
return Html::div()
->class('input-wrapper')
->content(
$input->class('modified-input'),
Html::label('Select item')
);
}
);
$cell = new Cell();
$data = ['id' => 42];
$context = new DataContext(
preparedDataReader: $this->dataReader,
column: $column,
data: $data,
key: 1,
index: 0
);
$renderer = new RadioColumnRenderer();

$result = $renderer->renderBody($column, $cell, $context);

$content = $result->getContent();
$this->assertStringContainsString('class="modified-input"', (string)$content[0]);
$this->assertStringContainsString('class="input-wrapper"', (string)$content[0]);
}

public function testRenderBodyPreservesExistingInputAttributes(): void
{
$column = new RadioColumn(
inputAttributes: [
'class' => 'custom-radio',
'data-test' => 'test-value',
'aria-label' => 'Select option',
'name' => 'custom-name',
'value' => 'custom-value',
]
);
$cell = new Cell();
$data = ['id' => 42];
$context = new DataContext(
preparedDataReader: $this->dataReader,
column: $column,
data: $data,
key: 1,
index: 0
);
$renderer = new RadioColumnRenderer();

$result = $renderer->renderBody($column, $cell, $context);

$content = $result->getContent();
$this->assertStringContainsString('class="custom-radio"', (string)$content[0]);
$this->assertStringContainsString('data-test="test-value"', (string)$content[0]);
$this->assertStringContainsString('aria-label="Select option"', (string)$content[0]);
$this->assertStringContainsString('name="custom-name"', (string)$content[0]);
$this->assertStringContainsString('value="custom-value"', (string)$content[0]);
}

public function testRenderBodyWithCustomizedHtmlStructure(): void
{
$column = new RadioColumn(
inputAttributes: [
'class' => 'form-check-input custom-radio',
'id' => 'radio-42',
'aria-label' => 'Select option',
],
content: static function($input) {
return Html::div()
->class('form-check custom-control')
->attributes(['data-test' => 'radio-wrapper'])
->content(
$input,
Html::span('✓')->class('check-mark'),
Html::label()
->class('form-check-label')
->attributes(['for' => 'radio-42'])
->content('Select option')
);
}
);
$cell = new Cell();
$data = ['id' => 42];
$context = new DataContext(
preparedDataReader: $this->dataReader,
column: $column,
data: $data,
key: 1,
index: 0
);
$renderer = new RadioColumnRenderer();

$result = $renderer->renderBody($column, $cell, $context);

$content = $result->getContent();
$this->assertStringContainsString('form-check-input', (string)$content[0]);
$this->assertStringContainsString('custom-radio', (string)$content[0]);
$this->assertStringContainsString('for="radio-42"', (string)$content[0]);
$this->assertStringContainsString('id="radio-42"', (string)$content[0]);
$this->assertStringContainsString('check-mark', (string)$content[0]);
$this->assertStringContainsString('Select option', (string)$content[0]);
}

public function testRenderBodyWithCustomizedHtmlStructureAndAttributes(): void
{
$column = new RadioColumn(
inputAttributes: [
'class' => 'form-check-input custom-radio',
'id' => 'radio-42',
'aria-label' => 'Select option',
'data-test' => 'test-value',
],
content: static function($input) {
return Html::div()
->class('form-check custom-control')
->attributes([
'data-test' => 'radio-wrapper',
'data-user-id' => '42',
])
->content(
$input,
Html::span('✓')->class('check-mark'),
Html::label()
->class('form-check-label')
->attributes(['for' => 'radio-42'])
->content('Select option')
);
}
);
$cell = new Cell();
$data = ['id' => 42];
$context = new DataContext(
preparedDataReader: $this->dataReader,
column: $column,
data: $data,
key: 1,
index: 0
);
$renderer = new RadioColumnRenderer();

$result = $renderer->renderBody($column, $cell, $context);

$content = $result->getContent();
$this->assertStringContainsString('form-check-input', (string)$content[0]);
$this->assertStringContainsString('custom-radio', (string)$content[0]);
$this->assertStringContainsString('data-test="test-value"', (string)$content[0]);
$this->assertStringContainsString('data-user-id="42"', (string)$content[0]);
$this->assertStringContainsString('for="radio-42"', (string)$content[0]);
$this->assertStringContainsString('id="radio-42"', (string)$content[0]);
$this->assertStringContainsString('check-mark', (string)$content[0]);
$this->assertStringContainsString('Select option', (string)$content[0]);
}

public function testRenderBodyWithDataFromContext(): void
{
$column = new RadioColumn(
inputAttributes: ['class' => 'form-check-input'],
content: static function($input, $context) {
return Html::div()
->class('form-check')
->content(
$input,
Html::label()
->class('form-check-label')
->content($context->data['name'])
);
}
);
$cell = new Cell();
$data = ['id' => 42, 'name' => 'Test User'];
$context = new DataContext(
preparedDataReader: $this->dataReader,
column: $column,
data: $data,
key: 1,
index: 0
);
$renderer = new RadioColumnRenderer();

$result = $renderer->renderBody($column, $cell, $context);

$content = $result->getContent();
$this->assertStringContainsString('Test User', (string)$content[0]);
$this->assertStringContainsString('class="form-check-label"', (string)$content[0]);
}
}
Loading
Loading