Skip to content

Improve DataField::$value type #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 10, 2025
Merged

Improve DataField::$value type #259

merged 3 commits into from
Mar 10, 2025

Conversation

vjik
Copy link
Member

@vjik vjik commented Mar 10, 2025

Q A
Is bugfix?
New feature?
Breaks BC? ✔️

Copy link

codecov bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.81%. Comparing base (5a09ab1) to head (e1d2be9).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/DetailView.php 89.47% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #259      +/-   ##
============================================
- Coverage     82.89%   82.81%   -0.08%     
+ Complexity      624      621       -3     
============================================
  Files            51       51              
  Lines          2110     2112       +2     
============================================
  Hits           1749     1749              
- Misses          361      363       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vjik vjik requested a review from a team March 10, 2025 07:16
@vjik vjik added the status:code review The pull request needs review. label Mar 10, 2025
@samdark samdark merged commit adc1f6b into master Mar 10, 2025
22 checks passed
@samdark samdark deleted the type-datafield-value branch March 10, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants