Skip to content

Cleanup #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 14, 2025
Merged

Cleanup #248

merged 3 commits into from
Feb 14, 2025

Conversation

vjik
Copy link
Member

@vjik vjik commented Feb 14, 2025

Q A
Is bugfix? ❌
New feature? ❌
Breaks BC? ✔️
  • Rename enableMultiSort to multiSort
  • Rename enableColumnGrouping to columnGrouping
  • Add default value for enableFooter() parameter

@vjik vjik added the status:code review The pull request needs review. label Feb 14, 2025
@vjik vjik requested a review from a team February 14, 2025 14:36
samdark
samdark approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good names 👍

@vjik vjik merged commit 89ac2a7 into master Feb 14, 2025
20 checks passed
@vjik vjik deleted the rename-enable branch February 14, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark approved these changes

Assignees
No one assigned
Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vjik @samdark