Fix #235. Rename attributes to properties. Rename methods #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankiFixx
commented
Jan 15, 2025
FrankiFixx
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
samdark
requested changes
Jan 16, 2025
Comment on lines
-284
to
+285
| '{attributes}' => Html::renderTagAttributes($this->attributes), | ||
| '{containerAttributes}' => Html::renderTagAttributes($this->containerAttributes), | ||
| '{attributes}' => Html::renderTagAttributes($this->properties), | ||
| '{containerAttributes}' => Html::renderTagAttributes($this->containerProperties), |
There was a problem hiding this comment.
This looks wrong. These are HTML tag attributes.
@vjik which properties/attributes did you mean?
There was a problem hiding this comment.
You're right. All HTML-related "attributes" must be keep.
Need to rename "attribute" that means "property of object": DataField::$attribute and related variables and methods.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #236 +/- ##
============================================
- Coverage 64.66% 62.31% -2.35%
- Complexity 558 639 +81
============================================
Files 46 52 +6
Lines 1862 2160 +298
============================================
+ Hits 1204 1346 +142
- Misses 658 814 +156 ☔ View full report in Codecov by Sentry. |
|
Seems to be done already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.