switching to express router #11
Conversation
There was a problem hiding this comment.
thanks for sending this, the code is much cleaner now. let's coordinate with @mohamedsaleh1984 since he'd sent some changes in the same area, or at least wait for him a day and then merge if there are no updates there. :)
| import { app } from './app'; | ||
| import { initDb } from './datastore'; | ||
|
|
||
| const initServer = async () => { |
| FOREIGN KEY (userId) REFERENCES users (id) | ||
| ); | ||
|
|
||
| CREATE TABLE likes ( |
There was a problem hiding this comment.
please add a new migration file with these changes, something like 002-add-likes.
the point of database migrations is that they're incremental, each change is isolated in a file so that the migration library can decide which changes don't exist in the db yet and need to be run.
| @@ -1,24 +1,26 @@ | |||
| { | |||
There was a problem hiding this comment.
nit: curious what happened with the formatting here. I was using two-spaces indentation, can we keep it this way? :)
| // Like APIs | ||
| export type CreateLikeRequest = Like; | ||
| export type CreateLikeResponse = { | ||
| message: string; |
There was a problem hiding this comment.
no need for the backend to send these back. the client should expect a successful (2xx) request to have acted on the like, and returning the same object the client sent in the request isn't probably all that useful. I'd keep this an empty interface until we have something useful to add here.
|
|
||
| // MIDDLEWARE | ||
| app.use(express.json()); | ||
| app.use(logger('dev')); |
There was a problem hiding this comment.
I don't know much about morgan, but it seems like a logging middleware, so we can't use it for manual logging correct? if so I think we'll need to use something different, or even cook up our own thing here. I'd like to not have to do console.log/error/warn and instead use the same logger with the same format for consistency.
| @@ -0,0 +1,2 @@ | |||
| export * from './userRouts'; | |||
There was a problem hiding this comment.
typo in both file names: userRoutes and postRoutes.
|
@MoustafaJazzar I'd like to move forward with the next parts, namely adding proper authentication. Would you be able to handle the comments and merge this PR soon? Otherwise you could rebase or merge my changes. :) |
2 participants
No description provided.