Skip to content

Conversation

asinghvi17
Copy link
Collaborator

@asinghvi17 asinghvi17 commented Jan 19, 2023

This doesn't work for FeatureCollections yet, and no tests have been added. It's essentially a quick and dirty implementation where I extended the type constraints on the main GeoInterface.convert method and implemented ArchGDAL.geointerface_geomtype(arg) = IGeometry. Since it operates on traits, it seemed a fair bet, and any feature-like object can of course be overloaded.

Changed the PR to just forward GeoInterface.centroid, which seemed to be missing.

@rafaqz
Copy link
Collaborator

rafaqz commented Jan 19, 2023

This is already tested as working. But yes we also need to handle features somehow. I guess I should have handle that in GeoInterface as well.

Noticed that this was missing, so decided to correct it.
@asinghvi17 asinghvi17 force-pushed the as/more_geointerface branch from 248236c to 1ab5bfa Compare January 26, 2023 09:09
@asinghvi17 asinghvi17 changed the title Allow GeoInterface.convert(ArchGDAL, obj) to "just work" Forward GeoInterface.centroid Jan 26, 2023
@asinghvi17 asinghvi17 requested a review from rafaqz January 26, 2023 09:10
@rafaqz
Copy link
Collaborator

rafaqz commented Jan 26, 2023

A test ?

for polygon and multipolygon within test_geometry.jl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants