Added IFeature type. Fixed memory leakage for Features.
#294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for catching this! Opened #295 so that comprehensive scrubbing of the codebase isn't blocking this fix from being merged. I still have some concern that we might be introducing a different bug with this change, and will be happy to merge once that's answered/addressed. The rest LGTM. |
yeesian
approved these changes
Apr 21, 2022
yeesian
requested changes
Apr 21, 2022
yeesian
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triggered by out of memory errors when working with a lot of GeoDataFrames.
It seems that
iteratejust allocatesFeatures without anyone ever cleaning them. This PR introduces anIFeature(and its parentAbstractFeature), which should align nicely with the other types.Since GeoDataFrames goes through quite some calls, it is a bit hard to find these things, but I expect this is not the only memory leak remaining.