-
Notifications
You must be signed in to change notification settings - Fork 697
ydb/core/wrappers/events: remove unnecessary dependency #20745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
on ydb/core/wrappers/ut_helpers; it is only used in various ut
🟢 |
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes an unnecessary dependency on the ut_helpers
module from the events
wrapper’s build configuration to streamline the dependency list.
- Deleted
ydb/core/wrappers/ut_helpers
fromya.make
since it’s only used in unit tests elsewhere - Verified CI still passes with reduced transitive dependencies on libxml
Comments suppressed due to low confidence (1)
ydb/core/wrappers/events/ya.make:19
- Ensure there are no remaining imports or references to
ut_helpers
in theevents
wrapper code to avoid build errors or dead code.
ydb/core/protos
on ydb/core/wrappers/ut_helpers; it is only used in various ut
Changelog entry
...
Changelog category
Description for reviewers
arcadia ci passed;
only purpose of this patch is to reduce list of deps on libxml