Skip to content

ydb/core/wrappers/events: remove unnecessary dependency #20745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025

Conversation

yumkam
Copy link
Collaborator

@yumkam yumkam commented Jul 7, 2025

on ydb/core/wrappers/ut_helpers; it is only used in various ut

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

arcadia ci passed;
only purpose of this patch is to reduce list of deps on libxml

on ydb/core/wrappers/ut_helpers; it is only used in various ut
Copy link

github-actions bot commented Jul 7, 2025

🟢 2025-07-07 16:20:07 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Jul 7, 2025

2025-07-07 16:10:35 UTC Pre-commit check linux-x86_64-relwithdebinfo for 96190f0 has started.
2025-07-07 16:10:47 UTC Artifacts will be uploaded here
2025-07-07 16:14:24 UTC ya make is running...
🟡 2025-07-07 17:58:07 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
31414 29994 0 6 1364 50

2025-07-07 18:01:00 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-07-07 18:13:31 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
502 (only retried tests) 462 0 0 2 38

🟢 2025-07-07 18:13:42 UTC Build successful.
🟢 2025-07-07 18:14:03 UTC ydbd size 2.2 GiB changed* by -18.6 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 9184024 merge: 96190f0 diff diff %
ydbd size 2 388 108 688 Bytes 2 388 089 616 Bytes -18.6 KiB -0.001%
ydbd stripped size 499 679 912 Bytes 499 675 880 Bytes -3.9 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 7, 2025

2025-07-07 16:12:18 UTC Pre-commit check linux-x86_64-release-asan for 96190f0 has started.
2025-07-07 16:12:31 UTC Artifacts will be uploaded here
2025-07-07 16:16:12 UTC ya make is running...
🟡 2025-07-07 18:39:30 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16015 15576 0 184 227 28

🟢 2025-07-07 18:41:00 UTC Build successful.
🟢 2025-07-07 18:41:30 UTC ydbd size 3.9 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: fff1a83 merge: 96190f0 diff diff %
ydbd size 4 200 367 888 Bytes 4 200 367 792 Bytes -96 Bytes -0.000%
ydbd stripped size 1 455 387 032 Bytes 1 455 386 968 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes an unnecessary dependency on the ut_helpers module from the events wrapper’s build configuration to streamline the dependency list.

  • Deleted ydb/core/wrappers/ut_helpers from ya.make since it’s only used in unit tests elsewhere
  • Verified CI still passes with reduced transitive dependencies on libxml
Comments suppressed due to low confidence (1)

ydb/core/wrappers/events/ya.make:19

  • Ensure there are no remaining imports or references to ut_helpers in the events wrapper code to avoid build errors or dead code.
        ydb/core/protos

@yumkam yumkam marked this pull request as ready for review July 7, 2025 17:41
@yumkam yumkam merged commit 5367fd8 into ydb-platform:main Jul 8, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants