Skip to content

Stable-25-1-2 Fix snapshots #20707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: stable-25-1-2
Choose a base branch
from

Conversation

nikvas0
Copy link
Collaborator

@nikvas0 nikvas0 commented Jul 7, 2025

Changelog entry

Fixes #20709. Need to acquire snapshot for dependant reads even in RW transaction.

Changelog category

  • Bugfix

Description for reviewers

#20652

@nikvas0 nikvas0 requested a review from a team as a code owner July 7, 2025 10:50
Copy link

github-actions bot commented Jul 7, 2025

🟢 2025-07-07 10:55:26 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Jul 7, 2025

2025-07-07 10:51:21 UTC Pre-commit check linux-x86_64-release-asan for e7f2f52 has started.
2025-07-07 10:51:33 UTC Artifacts will be uploaded here
2025-07-07 10:54:27 UTC ya make is running...
🟡 2025-07-07 12:12:44 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12425 12273 0 44 68 40

2025-07-07 12:13:50 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-07-07 12:34:40 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
192 (only retried tests) 91 0 8 57 36

2025-07-07 12:34:49 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-07-07 12:54:38 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
133 (only retried tests) 39 0 8 51 35

🟢 2025-07-07 12:54:46 UTC Build successful.
🟢 2025-07-07 12:55:17 UTC ydbd size 3.7 GiB changed* by +9.6 KiB, which is < 100.0 KiB vs stable-25-1-2: OK

ydbd size dash stable-25-1-2: 5c49af9 merge: e7f2f52 diff diff %
ydbd size 3 925 671 488 Bytes 3 925 681 344 Bytes +9.6 KiB +0.000%
ydbd stripped size 1 372 708 560 Bytes 1 372 714 512 Bytes +5.8 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 7, 2025

2025-07-07 10:51:33 UTC Pre-commit check linux-x86_64-relwithdebinfo for e7f2f52 has started.
2025-07-07 10:51:43 UTC Artifacts will be uploaded here
2025-07-07 10:54:37 UTC ya make is running...
🟡 2025-07-07 11:54:29 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19484 18213 0 3 1206 62

2025-07-07 11:56:19 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-07-07 12:16:27 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
124 (only retried tests) 63 0 0 0 61

🟢 2025-07-07 12:16:34 UTC Build successful.
🟢 2025-07-07 12:16:53 UTC ydbd size 2.1 GiB changed* by +3.0 KiB, which is < 100.0 KiB vs stable-25-1-2: OK

ydbd size dash stable-25-1-2: 5c49af9 merge: e7f2f52 diff diff %
ydbd size 2 256 785 232 Bytes 2 256 788 336 Bytes +3.0 KiB +0.000%
ydbd stripped size 477 635 608 Bytes 477 636 568 Bytes +960 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@gridnevvvit gridnevvvit self-requested a review July 7, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants