Skip to content

Stable-25-1 Fix snapshots #20706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025

Conversation

nikvas0
Copy link
Collaborator

@nikvas0 nikvas0 commented Jul 7, 2025

Changelog entry

Fixes #20709. Need to acquire snapshot for dependant reads even in RW transaction.

Changelog category

  • Bugfix

Description for reviewers

#20652

@nikvas0 nikvas0 requested a review from a team as a code owner July 7, 2025 10:48
Copy link

github-actions bot commented Jul 7, 2025

2025-07-07 10:49:27 UTC Pre-commit check linux-x86_64-relwithdebinfo for f5d3d62 has started.
2025-07-07 10:49:39 UTC Artifacts will be uploaded here
2025-07-07 10:52:30 UTC ya make is running...
🟡 2025-07-07 11:55:31 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19576 18301 0 5 1226 44

2025-07-07 11:57:16 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-07-07 12:17:15 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
92 (only retried tests) 51 0 0 0 41

🟢 2025-07-07 12:17:22 UTC Build successful.
🟢 2025-07-07 12:17:41 UTC ydbd size 2.1 GiB changed* by +3.0 KiB, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: 243a4e6 merge: f5d3d62 diff diff %
ydbd size 2 303 291 400 Bytes 2 303 294 520 Bytes +3.0 KiB +0.000%
ydbd stripped size 484 379 008 Bytes 484 379 968 Bytes +960 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 7, 2025

2025-07-07 10:49:27 UTC Pre-commit check linux-x86_64-release-asan for f5d3d62 has started.
2025-07-07 10:49:41 UTC Artifacts will be uploaded here
2025-07-07 10:52:34 UTC ya make is running...
🟡 2025-07-07 12:08:51 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12453 12343 0 41 31 38

2025-07-07 12:09:57 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-07-07 12:30:43 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
157 (only retried tests) 111 0 5 5 36

2025-07-07 12:30:52 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-07-07 12:50:42 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
76 (only retried tests) 40 0 2 0 34

🟢 2025-07-07 12:50:50 UTC Build successful.
🟢 2025-07-07 12:51:22 UTC ydbd size 3.7 GiB changed* by +5.6 KiB, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: 243a4e6 merge: f5d3d62 diff diff %
ydbd size 4 009 781 048 Bytes 4 009 786 808 Bytes +5.6 KiB +0.000%
ydbd stripped size 1 399 539 192 Bytes 1 399 541 048 Bytes +1.8 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 7, 2025

🟢 2025-07-07 11:20:39 UTC The validation of the Pull Request description is successful.

@nikvas0 nikvas0 merged commit 2dac5c9 into ydb-platform:stable-25-1 Jul 8, 2025
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants