Skip to content

YMQ: Do not send x-amz-crc32 HTTP header (AWS does not do it) (25-1-2) #20705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

qyryq
Copy link
Collaborator

@qyryq qyryq commented Jul 7, 2025

Changelog entry

YMQ: Do not send x-amz-crc32 HTTP header (AWS does not do it)

Changelog category

  • Improvement

Description for reviewers

YDBREQUESTS-5771

#20525

@qyryq qyryq requested a review from a team as a code owner July 7, 2025 10:47
@qyryq qyryq changed the title YMQ: Do not send x-amz-crc32 HTTP header (AWS does not do it) YMQ: Do not send x-amz-crc32 HTTP header (AWS does not do it) (25-1-2) Jul 7, 2025
Copy link

github-actions bot commented Jul 7, 2025

2025-07-07 10:48:56 UTC Pre-commit check linux-x86_64-relwithdebinfo for 361a1d6 has started.
2025-07-07 10:49:10 UTC Artifacts will be uploaded here
2025-07-07 10:51:56 UTC ya make is running...
🟡 2025-07-07 11:52:30 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18915 17622 0 4 1224 65

2025-07-07 11:54:07 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-07-07 12:15:07 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
149 (only retried tests) 86 0 0 2 61

🟢 2025-07-07 12:15:14 UTC Build successful.
🟢 2025-07-07 12:15:35 UTC ydbd size 2.1 GiB changed* by -2.7 KiB, which is <= 0 Bytes vs stable-25-1-2: OK

ydbd size dash stable-25-1-2: 5c49af9 merge: 361a1d6 diff diff %
ydbd size 2 256 785 232 Bytes 2 256 782 440 Bytes -2.7 KiB -0.000%
ydbd stripped size 477 635 608 Bytes 477 635 128 Bytes -480 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 7, 2025

2025-07-07 10:49:00 UTC Pre-commit check linux-x86_64-release-asan for 361a1d6 has started.
2025-07-07 10:49:11 UTC Artifacts will be uploaded here
2025-07-07 10:52:17 UTC ya make is running...
🟡 2025-07-07 12:10:32 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12065 11903 0 58 67 37

2025-07-07 12:11:38 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-07-07 12:32:13 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
213 (only retried tests) 108 0 8 61 36

2025-07-07 12:32:22 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-07-07 12:53:14 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
136 (only retried tests) 39 0 8 55 34

🟢 2025-07-07 12:53:24 UTC Build successful.
🟢 2025-07-07 12:53:55 UTC ydbd size 3.7 GiB changed* by -4.4 KiB, which is <= 0 Bytes vs stable-25-1-2: OK

ydbd size dash stable-25-1-2: 5c49af9 merge: 361a1d6 diff diff %
ydbd size 3 925 671 488 Bytes 3 925 666 992 Bytes -4.4 KiB -0.000%
ydbd stripped size 1 372 708 560 Bytes 1 372 707 152 Bytes -1.4 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 7, 2025

🟢 2025-07-07 10:50:45 UTC The validation of the Pull Request description is successful.

@qyryq qyryq merged commit 4fc63e1 into ydb-platform:stable-25-1-2 Jul 8, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants