Skip to content

YMQ: Do not send x-amz-crc32 HTTP header (AWS does not do it) (25-1) #20691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

qyryq
Copy link
Collaborator

@qyryq qyryq commented Jul 7, 2025

Changelog entry

YMQ: Do not send x-amz-crc32 HTTP header (AWS does not do it)

Changelog category

  • Improvement

Description for reviewers

#20525

@qyryq qyryq requested a review from a team as a code owner July 7, 2025 09:31
Copy link

github-actions bot commented Jul 7, 2025

🟢 2025-07-07 10:51:13 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Jul 7, 2025

2025-07-07 09:34:53 UTC Pre-commit check linux-x86_64-release-asan for 003e956 has started.
2025-07-07 09:35:05 UTC Artifacts will be uploaded here
2025-07-07 09:37:54 UTC ya make is running...
🟡 2025-07-07 10:51:45 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12096 11996 0 42 21 37

2025-07-07 10:52:50 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-07-07 11:12:40 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
143 (only retried tests) 105 0 3 2 33

2025-07-07 11:12:49 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-07-07 11:33:00 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
66 (only retried tests) 31 0 2 0 33

🟢 2025-07-07 11:33:07 UTC Build successful.
🟢 2025-07-07 11:33:37 UTC ydbd size 3.7 GiB changed* by -4.4 KiB, which is <= 0 Bytes vs stable-25-1: OK

ydbd size dash stable-25-1: 22f38c2 merge: 003e956 diff diff %
ydbd size 4 009 289 592 Bytes 4 009 285 096 Bytes -4.4 KiB -0.000%
ydbd stripped size 1 399 369 720 Bytes 1 399 368 312 Bytes -1.4 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 7, 2025

2025-07-07 09:34:57 UTC Pre-commit check linux-x86_64-relwithdebinfo for 003e956 has started.
2025-07-07 09:35:09 UTC Artifacts will be uploaded here
2025-07-07 09:38:05 UTC ya make is running...
🟡 2025-07-07 10:37:40 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19007 17730 0 8 1226 43

2025-07-07 10:39:17 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-07-07 10:59:17 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
98 (only retried tests) 52 0 0 5 41

🟢 2025-07-07 10:59:24 UTC Build successful.
🟢 2025-07-07 10:59:43 UTC ydbd size 2.1 GiB changed* by -2.7 KiB, which is <= 0 Bytes vs stable-25-1: OK

ydbd size dash stable-25-1: 22f38c2 merge: 003e956 diff diff %
ydbd size 2 302 997 648 Bytes 2 302 994 880 Bytes -2.7 KiB -0.000%
ydbd stripped size 484 321 664 Bytes 484 321 184 Bytes -480 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@qyryq qyryq changed the title YMQ: Do not send x-amz-crc32 HTTP header (AWS does not do it) YMQ: Do not send x-amz-crc32 HTTP header (AWS does not do it) (25-1) Jul 7, 2025
@qyryq qyryq merged commit ac2ebd4 into ydb-platform:stable-25-1 Jul 8, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants