YQ fixed ast output for ctas #20673
YQ fixed ast output for ctas #20673
Conversation
|
🔴 Bugfix requires a linked issue in the changelog entry |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that AST output is correctly captured and returned for CTAS (Create Table As Select) operations by enabling stats profiling in tests and accumulating ASTs in the session actor.
- Tests now run queries and scripts with
StatsMode::Profileand assert that ASTs are present. - The session actor collects per-statement ASTs into a vector and sets the combined AST on the final response.
- A new
QueryAstsmember was added to track ASTs across statements.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ydb/core/kqp/ut/federated_query/s3/kqp_federated_query_ut.cpp | Enabled Profile stats in test utilities and added assertions for GetAst() presence. |
| ydb/core/kqp/session_actor/kqp_session_actor.cpp | Collected GetQueryAst() results into QueryAsts and set joined AST string on response. |
| ydb/core/kqp/session_actor/kqp_query_state.h | Introduced TVector<TString> QueryAsts to store AST fragments across statements. |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
Fixed ast output for ctas
Changelog category
Description for reviewers