Skip to content

Finish LocalRecovery with error if ChunkReadResult is erroneous #20519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

serbel324
Copy link
Collaborator

@serbel324 serbel324 commented Jul 2, 2025

Changelog entry

We have issue when VDisk hangs in endless local recovery if ChunkRead request fails, because it causes Loader actor to switch to terminate state without notifying its parents. This change will allow loader actor to terminate properly on PDisk errors, and LocalRecovery to get notified about this error and to finish with proper status.
#20520

Changelog category

  • Bugfix

Copy link

github-actions bot commented Jul 2, 2025

2025-07-02 13:08:27 UTC Pre-commit check linux-x86_64-release-asan for 078203b has started.
2025-07-02 13:08:30 UTC Artifacts will be uploaded here
2025-07-02 13:11:54 UTC ya make is running...
2025-07-02 14:05:20 UTC Check cancelled

Copy link

github-actions bot commented Jul 2, 2025

🟢 2025-07-02 13:16:59 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Jul 2, 2025

2025-07-02 13:10:34 UTC Pre-commit check linux-x86_64-relwithdebinfo for 078203b has started.
2025-07-02 13:10:45 UTC Artifacts will be uploaded here
2025-07-02 13:13:57 UTC ya make is running...
2025-07-02 14:05:04 UTC Check cancelled

@serbel324 serbel324 force-pushed the bs/vdisk/recovery-failure-error-state branch from b4dc680 to 507735a Compare July 2, 2025 14:04
Copy link

github-actions bot commented Jul 2, 2025

2025-07-02 14:07:52 UTC Pre-commit check linux-x86_64-release-asan for 90b3e89 has started.
2025-07-02 14:08:03 UTC Artifacts will be uploaded here
2025-07-02 14:11:21 UTC ya make is running...
🔴 2025-07-02 14:16:43 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Jul 2, 2025

2025-07-02 14:08:02 UTC Pre-commit check linux-x86_64-relwithdebinfo for 90b3e89 has started.
2025-07-02 14:08:13 UTC Artifacts will be uploaded here
2025-07-02 14:11:42 UTC ya make is running...
🔴 2025-07-02 14:15:13 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Jul 2, 2025

2025-07-02 16:19:56 UTC Pre-commit check linux-x86_64-release-asan for 81d8680 has started.
2025-07-02 16:20:07 UTC Artifacts will be uploaded here
2025-07-02 16:23:19 UTC ya make is running...
🟡 2025-07-02 18:01:04 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14624 14306 0 100 186 32

🟢 2025-07-02 18:02:18 UTC Build successful.
🟢 2025-07-02 18:02:45 UTC ydbd size 3.9 GiB changed* by +1.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 6c11b88 merge: 81d8680 diff diff %
ydbd size 4 199 912 528 Bytes 4 199 914 040 Bytes +1.5 KiB +0.000%
ydbd stripped size 1 455 275 960 Bytes 1 455 276 792 Bytes +832 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 2, 2025

2025-07-02 16:20:06 UTC Pre-commit check linux-x86_64-relwithdebinfo for 81d8680 has started.
2025-07-02 16:20:17 UTC Artifacts will be uploaded here
2025-07-02 16:23:38 UTC ya make is running...
🟡 2025-07-02 17:26:56 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30010 28595 0 5 1363 47

2025-07-02 17:29:26 UTC ya make is running... (failed tests rerun, try 2)

@serbel324 serbel324 added the rebase-and-check Rebase PR with the current base branch and check label Jul 3, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Jul 3, 2025
Copy link

github-actions bot commented Jul 3, 2025

2025-07-03 15:02:49 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6acc84b has started.
2025-07-03 15:03:15 UTC Artifacts will be uploaded here
2025-07-03 15:07:02 UTC ya make is running...
🟡 2025-07-03 16:07:14 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30021 28609 0 2 1363 47

2025-07-03 16:10:02 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-07-03 16:20:38 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
519 (only retried tests) 486 0 0 2 31

🟢 2025-07-03 16:20:49 UTC Build successful.
🟢 2025-07-03 16:21:09 UTC ydbd size 2.2 GiB changed* by +2.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0982e87 merge: 6acc84b diff diff %
ydbd size 2 387 574 488 Bytes 2 387 576 504 Bytes +2.0 KiB +0.000%
ydbd stripped size 499 575 336 Bytes 499 575 848 Bytes +512 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 3, 2025

2025-07-03 15:04:12 UTC Pre-commit check linux-x86_64-release-asan for 6acc84b has started.
2025-07-03 15:04:25 UTC Artifacts will be uploaded here
2025-07-03 15:07:59 UTC ya make is running...
🟡 2025-07-03 16:56:38 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14635 14227 0 152 227 29

🟢 2025-07-03 16:57:55 UTC Build successful.
🟢 2025-07-03 16:58:23 UTC ydbd size 3.9 GiB changed* by +1.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: cbac0bf merge: 6acc84b diff diff %
ydbd size 4 199 991 736 Bytes 4 199 993 216 Bytes +1.4 KiB +0.000%
ydbd stripped size 1 455 315 992 Bytes 1 455 319 576 Bytes +3.5 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant