Skip to content

[KQP Constant folding] Do not fold SafeCast because it could produce unexpected result #20457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: stable-25-1-analytics
Choose a base branch
from

Conversation

denis0x0D
Copy link
Contributor

Changelog entry

Do not fold SafeCast because it could produce unexpected result
Fix for KIKIMR-23489

Changelog category

  • Bugfix

Description for reviewers

Fix for KIKIMR-23489

@denis0x0D denis0x0D requested a review from a team as a code owner July 1, 2025 14:58
Copy link

github-actions bot commented Jul 1, 2025

2025-07-01 15:04:49 UTC Pre-commit check linux-x86_64-release-asan for 67e86e7 has started.
2025-07-01 15:05:14 UTC Artifacts will be uploaded here
2025-07-01 15:08:41 UTC ya make is running...
🟡 2025-07-01 16:09:06 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12000 11891 0 53 27 29

2025-07-01 16:10:11 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-07-01 16:28:57 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
153 (only retried tests) 121 0 1 5 26

2025-07-01 16:29:08 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-07-01 16:45:03 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
55 (only retried tests) 23 0 1 5 26

🟢 2025-07-01 16:45:11 UTC Build successful.
🟢 2025-07-01 16:45:39 UTC ydbd size 3.7 GiB changed* by +66.0 KiB, which is < 100.0 KiB vs stable-25-1-analytics: OK

ydbd size dash stable-25-1-analytics: fdf7a57 merge: 67e86e7 diff diff %
ydbd size 3 989 266 048 Bytes 3 989 333 584 Bytes +66.0 KiB +0.002%
ydbd stripped size 1 393 115 464 Bytes 1 393 128 008 Bytes +12.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 1, 2025

2025-07-01 15:08:02 UTC Pre-commit check linux-x86_64-relwithdebinfo for 67e86e7 has started.
2025-07-01 15:08:48 UTC Artifacts will be uploaded here
2025-07-01 15:12:05 UTC ya make is running...
🟡 2025-07-01 16:02:41 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18846 17572 0 4 1224 46

2025-07-01 16:04:23 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-07-01 16:16:44 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
96 (only retried tests) 53 0 0 3 40

🟢 2025-07-01 16:16:51 UTC Build successful.
🟢 2025-07-01 16:17:09 UTC ydbd size 2.1 GiB changed* by +25.4 KiB, which is < 100.0 KiB vs stable-25-1-analytics: OK

ydbd size dash stable-25-1-analytics: fdf7a57 merge: 67e86e7 diff diff %
ydbd size 2 291 340 656 Bytes 2 291 366 664 Bytes +25.4 KiB +0.001%
ydbd stripped size 482 028 096 Bytes 482 030 144 Bytes +2.0 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants