Skip to content

[C++ SDK] Add traceparent to TRequestSettings #17561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 23, 2025
Merged

[C++ SDK] Add traceparent to TRequestSettings #17561

merged 3 commits into from
Apr 23, 2025

Conversation

zarinatlupova
Copy link
Contributor

Changelog entry

Added support for traceparent and updated gRPC client and request settings in the C++ SDK.

Changelog category

  • New feature

Description for reviewers

Migrate traceparent changes from ydb-cpp-sdk PR #400
This change adds support for traceparent and updates client settings.
Move SDK code to ydb/public/sdk/cpp

@zarinatlupova zarinatlupova requested a review from a team as a code owner April 22, 2025 14:58
@github-actions GitHub Actions
Copy link

Hi! Thank you for contributing!
The tests on this PR will run after a maintainer adds an ok-to-test label to this PR manually. Thank you for your patience!

@github-actions GitHub Actions
Copy link

🟢 2025-04-22 14:59:34 UTC The validation of the Pull Request description is successful.

@Gazizonoki Gazizonoki added the ok-to-test Special label used to approve a PR for testing on our infrastructure label Apr 22, 2025
@github-actions github-actions bot removed the ok-to-test Special label used to approve a PR for testing on our infrastructure label Apr 22, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 22, 2025 •
edited
Loading

⚪ 2025-04-22 15:06:29 UTC Pre-commit check linux-x86_64-relwithdebinfo for 61d2e15 has started.
⚪ 2025-04-22 15:06:50 UTC Artifacts will be uploaded here
⚪ 2025-04-22 15:10:25 UTC ya make is running...
🔴 2025-04-22 15:13:13 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 22, 2025 •
edited
Loading

⚪ 2025-04-22 15:13:07 UTC Pre-commit check linux-x86_64-release-asan for 61d2e15 has started.
⚪ 2025-04-22 15:13:36 UTC Artifacts will be uploaded here
⚪ 2025-04-22 15:17:01 UTC ya make is running...
🔴 2025-04-22 15:19:18 UTC Build failed, see the logs. Also see fail summary

Gazizonoki
Gazizonoki reviewed Apr 23, 2025
View reviewed changes
ydb/public/sdk/cpp/include/ydb-cpp-sdk/client/types/request_settings.h Outdated
@@ -29,6 +31,7 @@ struct TRequestSettings {
, RequestType_(other.RequestType_)
, Header_(other.Header_)
, ClientTimeout_(other.ClientTimeout_)
, TraceParent_(other.TraceParent)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
, TraceParent_(other.TraceParent)
, TraceParent_(other.TraceParent_)

@Gazizonoki Gazizonoki added the ok-to-test Special label used to approve a PR for testing on our infrastructure label Apr 23, 2025
@github-actions github-actions bot removed the ok-to-test Special label used to approve a PR for testing on our infrastructure label Apr 23, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 23, 2025 •
edited
Loading

⚪ 2025-04-23 10:41:51 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7078010 has started.
⚪ 2025-04-23 10:42:31 UTC Artifacts will be uploaded here
⚪ 2025-04-23 10:45:45 UTC ya make is running...
🟡 2025-04-23 12:11:05 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
29440 26732 0 5 2599 104

⚪ 2025-04-23 12:13:32 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-23 12:26:44 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
184 (only retried tests) 89 0 1 2 92

⚪ 2025-04-23 12:26:52 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-04-23 12:39:12 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
122 (only retried tests) 32 0 0 0 90

🟢 2025-04-23 12:39:20 UTC Build successful.
🟡 2025-04-23 12:39:41 UTC ydbd size 2.2 GiB changed* by +242.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 8404d71 merge: 7078010 diff diff %
ydbd size 2 353 135 864 Bytes 2 353 384 288 Bytes +242.6 KiB +0.011%
ydbd stripped size 493 967 968 Bytes 493 994 720 Bytes +26.1 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 23, 2025 •
edited
Loading

⚪ 2025-04-23 10:42:25 UTC Pre-commit check linux-x86_64-release-asan for 7078010 has started.
⚪ 2025-04-23 10:42:41 UTC Artifacts will be uploaded here
⚪ 2025-04-23 10:45:43 UTC ya make is running...
🟡 2025-04-23 12:22:14 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14722 14568 0 85 46 23

⚪ 2025-04-23 12:23:29 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-23 12:36:41 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
186 (only retried tests) 102 0 38 24 22

⚪ 2025-04-23 12:36:50 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-23 12:49:43 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
107 (only retried tests) 41 0 36 9 21

🟢 2025-04-23 12:49:52 UTC Build successful.
🟡 2025-04-23 12:50:22 UTC ydbd size 3.9 GiB changed* by +365.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 9731c04 merge: 7078010 diff diff %
ydbd size 4 133 758 840 Bytes 4 134 132 968 Bytes +365.4 KiB +0.009%
ydbd stripped size 1 431 217 464 Bytes 1 431 299 768 Bytes +80.4 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Gazizonoki Gazizonoki merged commit 0ab1114 into ydb-platform:main Apr 23, 2025
18 checks passed
@Gazizonoki Gazizonoki mentioned this pull request May 13, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gazizonoki Gazizonoki Gazizonoki approved these changes

Assignees
No one assigned
Labels
external new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zarinatlupova @Gazizonoki