Skip to content

Validate consumer attributes: fail on unknown attributes #17492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

UgnineSirdis
Copy link
Collaborator

Changelog entry

Validate consumer attributes: fail on unsupported consumer attributes.

Changelog category

  • Bugfix

Description for reviewers

Validate consumer attributes like this is done for topic attributes

Copy link

github-actions bot commented Apr 21, 2025

2025-04-21 13:50:33 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7775a5e has started.
2025-04-21 13:50:48 UTC Artifacts will be uploaded here
2025-04-21 13:53:39 UTC ya make is running...
2025-04-21 13:54:22 UTC Check cancelled

Copy link

github-actions bot commented Apr 21, 2025

2025-04-21 13:50:39 UTC Pre-commit check linux-x86_64-release-asan for 7775a5e has started.
2025-04-21 13:50:54 UTC Artifacts will be uploaded here
2025-04-21 13:53:44 UTC ya make is running...
2025-04-21 13:54:22 UTC Check cancelled

Copy link

🔴 2025-04-21 13:52:01 UTC The validation of the Pull Request description has failed. Please update the description.

Bugfix requires a linked issue in the changelog entry

@UgnineSirdis UgnineSirdis force-pushed the validate-consumer-attributes branch from 3cfaf9f to 2a9f653 Compare April 21, 2025 13:54
Copy link

github-actions bot commented Apr 21, 2025

2025-04-21 13:55:49 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5d24449 has started.
2025-04-21 13:56:04 UTC Artifacts will be uploaded here
2025-04-21 13:58:52 UTC ya make is running...
🟡 2025-04-21 15:55:46 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19930 18552 0 7 1265 106

2025-04-21 15:57:32 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-04-21 16:22:54 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
170 (only retried tests) 74 0 0 0 96

🟢 2025-04-21 16:23:01 UTC Build successful.
🟢 2025-04-21 16:23:27 UTC ydbd size 2.2 GiB changed* by +368 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 9a6920b merge: 5d24449 diff diff %
ydbd size 2 351 384 608 Bytes 2 351 384 976 Bytes +368 Bytes +0.000%
ydbd stripped size 493 681 152 Bytes 493 681 216 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Apr 21, 2025

2025-04-21 13:58:16 UTC Pre-commit check linux-x86_64-release-asan for 5d24449 has started.
2025-04-21 13:58:32 UTC Artifacts will be uploaded here
2025-04-21 14:01:25 UTC ya make is running...
🟡 2025-04-21 16:12:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12494 12283 0 110 75 26

2025-04-21 16:13:28 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-21 16:27:29 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
267 (only retried tests) 175 0 42 26 24

2025-04-21 16:27:39 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-21 16:41:19 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
115 (only retried tests) 38 0 37 17 23

🟢 2025-04-21 16:41:26 UTC Build successful.
🟢 2025-04-21 16:42:01 UTC ydbd size 3.8 GiB changed* by +2.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 9a6920b merge: 5d24449 diff diff %
ydbd size 4 130 236 808 Bytes 4 130 239 232 Bytes +2.4 KiB +0.000%
ydbd stripped size 1 430 083 288 Bytes 1 430 083 992 Bytes +704 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant