Skip to content

Left join with predicate rewrite fix #16187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Left join with predicate rewrite fix #16187

wants to merge 1 commit into from

Conversation

denis0x0D
Copy link
Contributor

Changelog entry

Fix #16098

Changelog category

  • Bugfix

Description for reviewers

...

@denis0x0D denis0x0D requested a review from a team as a code owner March 24, 2025 18:11
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 24, 2025 •
edited
Loading

🔴 2025-03-25 18:12:28 UTC The validation of the Pull Request description has failed. Please update the description.

The changelog entry is less than 20 characters or missing.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 24, 2025 •
edited
Loading

⚪ 2025-03-24 18:12:42 UTC Pre-commit check linux-x86_64-release-asan for a7ca81c has started.
⚪ 2025-03-24 18:13:19 UTC Artifacts will be uploaded here
⚪ 2025-03-24 18:16:37 UTC ya make is running...
🟡 2025-03-24 19:39:14 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12620 12532 0 48 8 32

⚪ 2025-03-24 19:40:19 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-24 19:52:31 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
134 (only retried tests) 95 0 6 5 28

⚪ 2025-03-24 19:52:39 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-24 20:03:49 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
64 (only retried tests) 32 0 5 1 26

🟢 2025-03-24 20:03:55 UTC Build successful.
🟡 2025-03-24 20:04:22 UTC ydbd size 3.8 GiB changed* by +514.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 9130056 merge: a7ca81c diff diff %
ydbd size 4 081 777 168 Bytes 4 082 304 336 Bytes +514.8 KiB +0.013%
ydbd stripped size 1 410 254 760 Bytes 1 410 560 840 Bytes +298.9 KiB +0.022%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 24, 2025 •
edited
Loading

⚪ 2025-03-24 18:14:45 UTC Pre-commit check linux-x86_64-relwithdebinfo for a7ca81c has started.
⚪ 2025-03-24 18:15:00 UTC Artifacts will be uploaded here
⚪ 2025-03-24 18:17:58 UTC ya make is running...
🟡 2025-03-24 19:25:45 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27069 24443 0 11 2499 116

⚪ 2025-03-24 19:27:58 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-24 19:41:10 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
188 (only retried tests) 79 0 5 0 104

⚪ 2025-03-24 19:41:18 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-03-24 19:51:03 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
152 (only retried tests) 45 0 5 0 102

🟢 2025-03-24 19:51:12 UTC Build successful.
🟢 2025-03-24 19:51:34 UTC ydbd size 2.2 GiB changed* by -11.3 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: b10a177 merge: a7ca81c diff diff %
ydbd size 2 320 704 568 Bytes 2 320 692 984 Bytes -11.3 KiB -0.000%
ydbd stripped size 485 191 488 Bytes 485 188 736 Bytes -2.7 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@denis0x0D denis0x0D force-pushed the left_join_rewrite_fix branch from da0f4c1 to a2784e2 Compare March 25, 2025 08:12
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 25, 2025 •
edited
Loading

⚪ 2025-03-25 08:13:34 UTC Pre-commit check linux-x86_64-release-asan for 367a2c4 has started.
⚪ 2025-03-25 08:13:49 UTC Artifacts will be uploaded here
⚪ 2025-03-25 08:16:38 UTC ya make is running...
🟡 2025-03-25 09:29:03 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12623 12532 0 43 14 34

⚪ 2025-03-25 09:30:09 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-25 09:42:33 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
139 (only retried tests) 93 0 6 9 31

⚪ 2025-03-25 09:42:46 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-25 09:54:19 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
74 (only retried tests) 36 0 5 3 30

🟢 2025-03-25 09:54:28 UTC Build successful.
🟢 2025-03-25 09:54:56 UTC ydbd size 3.8 GiB changed* by -13.6 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 70be00c merge: 367a2c4 diff diff %
ydbd size 4 083 249 072 Bytes 4 083 235 112 Bytes -13.6 KiB -0.000%
ydbd stripped size 1 410 852 488 Bytes 1 410 848 904 Bytes -3.5 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 25, 2025 •
edited
Loading

⚪ 2025-03-25 08:15:48 UTC Pre-commit check linux-x86_64-relwithdebinfo for 367a2c4 has started.
⚪ 2025-03-25 08:16:04 UTC Artifacts will be uploaded here
⚪ 2025-03-25 08:18:56 UTC ya make is running...
🟡 2025-03-25 09:26:26 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27120 24444 0 9 2558 109

⚪ 2025-03-25 09:28:57 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-25 09:41:54 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
181 (only retried tests) 67 0 4 4 106

⚪ 2025-03-25 09:42:03 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-03-25 09:54:03 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
155 (only retried tests) 48 0 4 0 103

🟢 2025-03-25 09:54:15 UTC Build successful.
🟢 2025-03-25 09:54:39 UTC ydbd size 2.2 GiB changed* by -14.7 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 70be00c merge: 367a2c4 diff diff %
ydbd size 2 321 084 280 Bytes 2 321 069 216 Bytes -14.7 KiB -0.001%
ydbd stripped size 485 261 312 Bytes 485 254 528 Bytes -6.6 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

maximyurchuk
maximyurchuk reviewed Mar 25, 2025
View reviewed changes
yql/essentials/core/common_opt/yql_flatmap_over_join.cpp
@@ -317,6 +317,15 @@ void CountLabelsInputUsage(TExprNode::TPtr joinTree, THashMap<TString, int>& cou
}
}

void DecrementCountLabelsInputUsage(TExprNode::TPtr joinTree, THashMap<TString, int>& counters) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Директорию YQL через Аркадию надо править

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ага, пока тестируем. У них тестов нет на эту фичу в Аркадии

@denis0x0D denis0x0D force-pushed the left_join_rewrite_fix branch from a2784e2 to 7ba808a Compare March 25, 2025 18:07
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 25, 2025 •
edited
Loading

⚪ 2025-03-25 18:11:04 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4ed10e9 has started.
⚪ 2025-03-25 18:11:19 UTC Artifacts will be uploaded here
⚪ 2025-03-25 18:14:02 UTC ya make is running...

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 25, 2025 •
edited
Loading

⚪ 2025-03-25 18:11:05 UTC Pre-commit check linux-x86_64-release-asan for 4ed10e9 has started.
⚪ 2025-03-25 18:11:20 UTC Artifacts will be uploaded here
⚪ 2025-03-25 18:14:09 UTC ya make is running...

@denis0x0D denis0x0D changed the title Fix Left join with predicate rewrite fix Mar 25, 2025
@github-actions github-actions bot added bugfix and removed bugfix labels Mar 25, 2025
@denis0x0D denis0x0D force-pushed the left_join_rewrite_fix branch from 7ba808a to ca1a884 Compare March 25, 2025 18:21
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 25, 2025 •
edited
Loading

⚪ 2025-03-25 18:30:35 UTC Pre-commit check linux-x86_64-release-asan for 292f981 has started.
⚪ 2025-03-25 18:30:49 UTC Artifacts will be uploaded here
⚪ 2025-03-25 18:33:38 UTC ya make is running...
🟡 2025-03-25 19:48:31 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12625 12507 0 66 19 33

⚪ 2025-03-25 19:50:02 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-25 20:03:55 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
165 (only retried tests) 121 0 5 9 30

⚪ 2025-03-25 20:04:10 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-25 20:16:25 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
68 (only retried tests) 33 0 5 1 29

🟢 2025-03-25 20:16:36 UTC Build successful.
🟢 2025-03-25 20:17:06 UTC ydbd size 3.8 GiB changed* by +70.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f7971e1 merge: 292f981 diff diff %
ydbd size 4 085 067 968 Bytes 4 085 139 824 Bytes +70.2 KiB +0.002%
ydbd stripped size 1 411 362 856 Bytes 1 411 381 480 Bytes +18.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 25, 2025 •
edited
Loading

⚪ 2025-03-25 18:30:44 UTC Pre-commit check linux-x86_64-relwithdebinfo for 292f981 has started.
⚪ 2025-03-25 18:30:58 UTC Artifacts will be uploaded here
⚪ 2025-03-25 18:33:46 UTC ya make is running...
🟡 2025-03-25 19:40:17 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27132 24459 0 8 2557 108

⚪ 2025-03-25 19:42:40 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-25 19:55:23 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
173 (only retried tests) 69 0 4 0 100

⚪ 2025-03-25 19:55:32 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-03-25 20:06:35 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
142 (only retried tests) 41 0 4 0 97

🟢 2025-03-25 20:06:44 UTC Build successful.
🟢 2025-03-25 20:07:07 UTC ydbd size 2.2 GiB changed* by +28.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f7971e1 merge: 292f981 diff diff %
ydbd size 2 322 075 280 Bytes 2 322 104 392 Bytes +28.4 KiB +0.001%
ydbd stripped size 485 431 104 Bytes 485 434 624 Bytes +3.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximyurchuk maximyurchuk maximyurchuk left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rewriter for LEFT JOIN with Predicate on the right side does not work
2 participants
@denis0x0D @maximyurchuk