Skip to content

GroupLayoutSanitizer always monitors invalid groups, add UTs #15026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 28, 2025
Merged

GroupLayoutSanitizer always monitors invalid groups, add UTs #15026

merged 4 commits into from
Feb 28, 2025

Conversation

serbel324
Copy link
Collaborator

@serbel324 serbel324 commented Feb 25, 2025 •
edited
Loading

Changelog entry

...

Changelog category

  • New feature
  • Experimental feature
  • Improvement
  • Performance improvement
  • User Interface
  • Bugfix
  • Backward incompatible change
  • Documentation (changelog entry is not required)
  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 25, 2025 •
edited
Loading

🟢 2025-02-25 16:19:50 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 25, 2025 •
edited
Loading

⚪ 2025-02-25 16:22:24 UTC Pre-commit check linux-x86_64-release-asan for fb97bbc has started.
⚪ 2025-02-25 16:25:26 UTC Artifacts will be uploaded here
⚪ 2025-02-25 16:28:35 UTC ya make is running...
🟡 2025-02-25 18:10:04 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13707 13617 0 27 30 33

⚪ 2025-02-25 18:11:32 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-25 18:28:30 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
130 (only retried tests) 93 0 1 6 30

⚪ 2025-02-25 18:28:38 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-02-25 18:49:16 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
65 (only retried tests) 33 0 0 2 30

🟢 2025-02-25 18:49:23 UTC Build successful.
🟢 2025-02-25 18:49:52 UTC ydbd size 3.6 GiB changed* by +4.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b74ed72 merge: fb97bbc diff diff %
ydbd size 3 900 170 608 Bytes 3 900 175 056 Bytes +4.3 KiB +0.000%
ydbd stripped size 1 365 352 336 Bytes 1 365 353 104 Bytes +768 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 25, 2025 •
edited
Loading

⚪ 2025-02-25 16:22:44 UTC Pre-commit check linux-x86_64-relwithdebinfo for fb97bbc has started.
⚪ 2025-02-25 16:22:59 UTC Artifacts will be uploaded here
⚪ 2025-02-25 16:26:21 UTC ya make is running...
🟡 2025-02-25 18:01:01 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28086 25476 0 4 2462 144

⚪ 2025-02-25 18:03:57 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-25 18:16:28 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
212 (only retried tests) 82 0 0 2 128

🟢 2025-02-25 18:16:36 UTC Build successful.
🟢 2025-02-25 18:16:54 UTC ydbd size 2.1 GiB changed* by +2.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b74ed72 merge: fb97bbc diff diff %
ydbd size 2 243 239 880 Bytes 2 243 242 720 Bytes +2.8 KiB +0.000%
ydbd stripped size 474 910 200 Bytes 474 910 456 Bytes +256 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 26, 2025 •
edited
Loading

⚪ 2025-02-26 11:00:12 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0e8ab2e has started.
⚪ 2025-02-26 11:01:04 UTC Artifacts will be uploaded here
⚪ 2025-02-26 11:04:45 UTC ya make is running...
⚫ 2025-02-26 11:08:39 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 26, 2025 •
edited
Loading

⚪ 2025-02-26 11:03:05 UTC Pre-commit check linux-x86_64-release-asan for 0e8ab2e has started.
⚪ 2025-02-26 11:03:20 UTC Artifacts will be uploaded here
⚪ 2025-02-26 11:06:27 UTC ya make is running...
⚫ 2025-02-26 11:08:38 UTC Check cancelled

@serbel324 serbel324 force-pushed the bsc/gls/always-monitor branch from ec14be7 to 3eee562 Compare February 26, 2025 11:08
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 26, 2025 •
edited
Loading

⚪ 2025-02-26 11:10:00 UTC Pre-commit check linux-x86_64-release-asan for 514be7b has started.
⚪ 2025-02-26 11:10:07 UTC Artifacts will be uploaded here
⚪ 2025-02-26 11:13:10 UTC ya make is running...
⚫ 2025-02-26 11:47:39 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 26, 2025 •
edited
Loading

⚪ 2025-02-26 11:10:02 UTC Pre-commit check linux-x86_64-relwithdebinfo for 514be7b has started.
⚪ 2025-02-26 11:10:05 UTC Artifacts will be uploaded here
⚪ 2025-02-26 11:13:20 UTC ya make is running...
⚫ 2025-02-26 11:47:23 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 26, 2025 •
edited
Loading

⚪ 2025-02-26 11:50:45 UTC Pre-commit check linux-x86_64-relwithdebinfo for bd5840e has started.
⚪ 2025-02-26 11:50:58 UTC Artifacts will be uploaded here
⚪ 2025-02-26 11:54:06 UTC ya make is running...
🟡 2025-02-26 12:54:49 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28102 25508 0 2 2459 133

⚪ 2025-02-26 12:57:30 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-26 13:12:04 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
198 (only retried tests) 72 0 0 0 126

🟢 2025-02-26 13:12:11 UTC Build successful.
🟢 2025-02-26 13:12:28 UTC ydbd size 2.1 GiB changed* by +2.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 4fa7c1c merge: bd5840e diff diff %
ydbd size 2 265 216 328 Bytes 2 265 219 176 Bytes +2.8 KiB +0.000%
ydbd stripped size 477 290 904 Bytes 477 291 160 Bytes +256 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 26, 2025 •
edited
Loading

⚪ 2025-02-26 11:51:08 UTC Pre-commit check linux-x86_64-release-asan for bd5840e has started.
⚪ 2025-02-26 11:51:19 UTC Artifacts will be uploaded here
⚪ 2025-02-26 11:54:25 UTC ya make is running...
🟡 2025-02-26 13:12:14 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13714 13637 0 32 12 33

⚪ 2025-02-26 13:13:40 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-26 13:25:42 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
116 (only retried tests) 87 0 3 0 26

⚪ 2025-02-26 13:25:51 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-02-26 13:36:16 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
56 (only retried tests) 29 0 2 0 25

🟢 2025-02-26 13:36:24 UTC Build successful.
🟢 2025-02-26 13:36:51 UTC ydbd size 3.7 GiB changed* by +5.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 340fbf8 merge: bd5840e diff diff %
ydbd size 3 945 557 664 Bytes 3 945 562 928 Bytes +5.1 KiB +0.000%
ydbd stripped size 1 374 591 568 Bytes 1 374 592 528 Bytes +960 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@serbel324 serbel324 merged commit bf4f55b into ydb-platform:main Feb 28, 2025
12 checks passed
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 3, 2025
@serbel324
GroupLayoutSanitizer always monitors invalid groups, add UTs (ydb-pla…
7e4ac61 
…tform#15026)
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 4, 2025
Closed
This was referenced Mar 10, 2025
Merged
Merged
@alexnick88 alexnick88 mentioned this pull request Mar 19, 2025
Closed
StekPerepolnen pushed a commit to StekPerepolnen/ydb that referenced this pull request Mar 20, 2025
@serbel324 @StekPerepolnen
GroupLayoutSanitizer always monitors invalid groups, add UTs (ydb-pla…
4866f86 
…tform#15026)
@StekPerepolnen StekPerepolnen mentioned this pull request Mar 20, 2025
Merged
blinkov pushed a commit that referenced this pull request Mar 21, 2025
@serbel324 @blinkov
GroupLayoutSanitizer always monitors invalid groups, add UTs (#15026)
b9bf2b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexvru alexvru alexvru approved these changes

Assignees
No one assigned
Labels
new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serbel324 @alexvru