Skip to content

YQ-3535 RD supported optional columns as NULLs #10452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

GrigoriyPA
Copy link
Collaborator

@GrigoriyPA GrigoriyPA commented Oct 15, 2024

Changelog entry

Supported optional columns as NULLs

Changelog category

  • Improvement

Additional information

@GrigoriyPA GrigoriyPA requested a review from a team as a code owner October 15, 2024 12:29
Copy link

github-actions bot commented Oct 15, 2024

2024-10-15 12:31:15 UTC Pre-commit check linux-x86_64-relwithdebinfo for f8d71dd has started.
2024-10-15 12:31:25 UTC Artifacts will be uploaded here
2024-10-15 12:34:19 UTC ya make is running...
2024-10-15 13:03:02 UTC Check cancelled

Copy link

github-actions bot commented Oct 15, 2024

2024-10-15 12:31:37 UTC Pre-commit check linux-x86_64-release-asan for f8d71dd has started.
2024-10-15 12:31:48 UTC Artifacts will be uploaded here
2024-10-15 12:34:42 UTC ya make is running...
2024-10-15 13:03:12 UTC Check cancelled

Copy link

github-actions bot commented Oct 15, 2024

2024-10-15 13:05:39 UTC Pre-commit check linux-x86_64-release-asan for 9c3b102 has started.
2024-10-15 13:05:50 UTC Artifacts will be uploaded here
2024-10-15 13:08:44 UTC ya make is running...
🟡 2024-10-15 14:30:51 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10276 10042 0 70 56 108

🟢 2024-10-15 14:31:44 UTC Build successful.
🟢 2024-10-15 14:32:17 UTC ydbd size 5.7 GiB changed* by +8.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f1035af merge: 9c3b102 diff diff %
ydbd size 6 099 166 848 Bytes 6 099 175 696 Bytes +8.6 KiB +0.000%
ydbd stripped size 1 521 012 176 Bytes 1 521 014 992 Bytes +2.8 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 15, 2024

2024-10-15 13:05:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9c3b102 has started.
2024-10-15 13:06:03 UTC Artifacts will be uploaded here
2024-10-15 13:08:57 UTC ya make is running...
🟡 2024-10-15 14:02:04 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39824 34237 0 1 5480 106

2024-10-15 14:05:21 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-15 14:17:03 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
106 (only retried tests) 5 0 0 1 100

🟢 2024-10-15 14:17:09 UTC Build successful.
🟢 2024-10-15 14:17:28 UTC ydbd size 2.8 GiB changed* by +3.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f1035af merge: 9c3b102 diff diff %
ydbd size 3 010 572 128 Bytes 3 010 575 840 Bytes +3.6 KiB +0.000%
ydbd stripped size 477 545 624 Bytes 477 546 648 Bytes +1.0 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

kardymonds
kardymonds previously approved these changes Oct 15, 2024
Copy link

github-actions bot commented Oct 15, 2024

2024-10-15 14:41:42 UTC Pre-commit check linux-x86_64-relwithdebinfo for fd0a19f has started.
2024-10-15 14:42:19 UTC Artifacts will be uploaded here
2024-10-15 14:45:46 UTC ya make is running...
2024-10-15 15:15:16 UTC Check cancelled

Copy link

github-actions bot commented Oct 15, 2024

2024-10-15 14:42:10 UTC Pre-commit check linux-x86_64-release-asan for fd0a19f has started.
2024-10-15 14:42:40 UTC Artifacts will be uploaded here
2024-10-15 14:46:07 UTC ya make is running...
2024-10-15 15:15:34 UTC Check cancelled

Copy link

github-actions bot commented Oct 15, 2024

2024-10-15 15:16:19 UTC Pre-commit check linux-x86_64-release-asan for 2745072 has started.
2024-10-15 15:16:23 UTC Artifacts will be uploaded here
2024-10-15 15:19:16 UTC ya make is running...
🟡 2024-10-15 16:39:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10264 9880 0 70 271 43

🟢 2024-10-15 16:40:15 UTC Build successful.
🟡 2024-10-15 16:40:49 UTC ydbd size 5.7 GiB changed* by +111.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 168df93 merge: 2745072 diff diff %
ydbd size 6 099 277 304 Bytes 6 099 391 688 Bytes +111.7 KiB +0.002%
ydbd stripped size 1 521 027 088 Bytes 1 521 057 808 Bytes +30.0 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 15, 2024

2024-10-15 15:19:42 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2745072 has started.
2024-10-15 15:19:53 UTC Artifacts will be uploaded here
2024-10-15 15:22:56 UTC ya make is running...
🟡 2024-10-15 16:17:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39827 34239 0 2 5480 106

2024-10-15 16:20:46 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-15 16:32:09 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
106 (only retried tests) 7 0 0 0 99

🟢 2024-10-15 16:32:16 UTC Build successful.
🟢 2024-10-15 16:32:34 UTC ydbd size 2.8 GiB changed* by +3.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 3ab7dd7 merge: 2745072 diff diff %
ydbd size 3 010 665 048 Bytes 3 010 668 680 Bytes +3.5 KiB +0.000%
ydbd stripped size 477 552 856 Bytes 477 553 816 Bytes +960 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@GrigoriyPA GrigoriyPA merged commit b46ef3e into ydb-platform:main Oct 15, 2024
10 checks passed
@GrigoriyPA GrigoriyPA deleted the YQ-3535-support-optional-fields branch October 15, 2024 17:18
kardymonds pushed a commit to kardymonds/ydb that referenced this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants