Skip to content

Add index to resultsets #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/query/test_query_session_pool.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,12 @@ def test_oneshot_query_normal(self, pool: QuerySessionPool):
res = pool.execute_with_retries("select 1;")
assert len(res) == 1

def test_oneshot_query_result_set_index(self, pool: QuerySessionPool):
res = pool.execute_with_retries("select 1; select 2; select 3")
assert len(res) == 3
indexes = [result_set.index for result_set in res]
assert indexes == [0, 1, 2]

def test_oneshot_ddl_query(self, pool: QuerySessionPool):
pool.execute_with_retries("create table Queen(key UInt64, PRIMARY KEY (key));")
pool.execute_with_retries("drop table Queen;")
Expand Down
9 changes: 5 additions & 4 deletions ydb/convert.py
Original file line number Diff line number Diff line change
Expand Up @@ -352,16 +352,17 @@ def _unwrap_optionality(column):


class _ResultSet(object):
__slots__ = ("columns", "rows", "truncated", "snapshot")
__slots__ = ("columns", "rows", "truncated", "snapshot", "index")

def __init__(self, columns, rows, truncated, snapshot=None):
def __init__(self, columns, rows, truncated, snapshot=None, index=None):
self.columns = columns
self.rows = rows
self.truncated = truncated
self.snapshot = snapshot
self.index = index

@classmethod
def from_message(cls, message, table_client_settings=None, snapshot=None):
def from_message(cls, message, table_client_settings=None, snapshot=None, index=None):
rows = []
# prepare column parsers before actuall parsing
column_parsers = []
Expand All @@ -384,7 +385,7 @@ def from_message(cls, message, table_client_settings=None, snapshot=None):
column_parser, unwrapped_type = column_info
row[column.name] = column_parser(unwrapped_type, value, table_client_settings)
rows.append(row)
return cls(message.columns, rows, message.truncated, snapshot)
return cls(message.columns, rows, message.truncated, snapshot, index)

@classmethod
def lazy_from_message(cls, message, table_client_settings=None, snapshot=None):
Expand Down
6 changes: 5 additions & 1 deletion ydb/query/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,11 @@ def wrap_execute_query_response(
session._last_query_stats = response_pb.exec_stats

if response_pb.HasField("result_set"):
return convert.ResultSet.from_message(response_pb.result_set, settings)
return convert.ResultSet.from_message(
response_pb.result_set,
settings,
index=response_pb.result_set_index,
)

return None

Expand Down
Loading