-
Notifications
You must be signed in to change notification settings - Fork 58
Partition autosplit feature #549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
213253f
Partition autosplit feature
vgvoleg 7c607f5
Auto partitioning settings to public api
vgvoleg 4f38b65
style fixes
vgvoleg f765537
Fix unit
vgvoleg f68af4c
auto partitioning control plane
vgvoleg 0d5fa7b
Stop rotation batch queue after split
vgvoleg 0f20070
test autosplit message order
vgvoleg 818acdd
remove default values from proto DTO
vgvoleg f5099d3
make auto_partitioning_support enabled by default
vgvoleg 3da64a0
add autosplit example
vgvoleg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -419,12 +419,14 @@ def from_proto( | |
class InitRequest(IToProto): | ||
topics_read_settings: List["StreamReadMessage.InitRequest.TopicReadSettings"] | ||
consumer: str | ||
auto_partitioning_support: bool = False | ||
|
||
def to_proto(self) -> ydb_topic_pb2.StreamReadMessage.InitRequest: | ||
res = ydb_topic_pb2.StreamReadMessage.InitRequest() | ||
res.consumer = self.consumer | ||
for settings in self.topics_read_settings: | ||
res.topics_read_settings.append(settings.to_proto()) | ||
res.auto_partitioning_support = self.auto_partitioning_support | ||
return res | ||
|
||
@dataclass | ||
|
@@ -696,6 +698,20 @@ def to_proto(self) -> ydb_topic_pb2.StreamReadMessage.StopPartitionSessionRespon | |
partition_session_id=self.partition_session_id, | ||
) | ||
|
||
@dataclass | ||
class EndPartitionSession(IFromProto): | ||
partition_session_id: int | ||
adjacent_partition_ids: List[int] | ||
child_partition_ids: List[int] | ||
|
||
@staticmethod | ||
def from_proto(msg: ydb_topic_pb2.StreamReadMessage.EndPartitionSession): | ||
return StreamReadMessage.EndPartitionSession( | ||
partition_session_id=msg.partition_session_id, | ||
adjacent_partition_ids=list(msg.adjacent_partition_ids), | ||
child_partition_ids=list(msg.child_partition_ids), | ||
) | ||
|
||
@dataclass | ||
class FromClient(IToProto): | ||
client_message: "ReaderMessagesFromClientToServer" | ||
|
@@ -775,6 +791,13 @@ def from_proto( | |
msg.partition_session_status_response | ||
), | ||
) | ||
elif mess_type == "end_partition_session": | ||
return StreamReadMessage.FromServer( | ||
server_status=server_status, | ||
server_message=StreamReadMessage.EndPartitionSession.from_proto( | ||
msg.end_partition_session, | ||
), | ||
) | ||
else: | ||
raise issues.UnexpectedGrpcMessage( | ||
"Unexpected message while parse ReaderMessagesFromServerToClient: '%s'" % mess_type | ||
|
@@ -799,6 +822,7 @@ def from_proto( | |
UpdateTokenResponse, | ||
StreamReadMessage.StartPartitionSessionRequest, | ||
StreamReadMessage.StopPartitionSessionRequest, | ||
StreamReadMessage.EndPartitionSession, | ||
] | ||
|
||
|
||
|
@@ -943,30 +967,196 @@ def from_public(alter_consumer: ydb_topic_public_types.PublicAlterConsumer) -> A | |
class PartitioningSettings(IToProto, IFromProto): | ||
min_active_partitions: int | ||
partition_count_limit: int | ||
max_active_partitions: int | ||
auto_partitioning_settings: AutoPartitioningSettings | ||
|
||
@staticmethod | ||
def from_proto(msg: ydb_topic_pb2.PartitioningSettings) -> "PartitioningSettings": | ||
return PartitioningSettings( | ||
min_active_partitions=msg.min_active_partitions, | ||
partition_count_limit=msg.partition_count_limit, | ||
max_active_partitions=msg.max_active_partitions, | ||
auto_partitioning_settings=AutoPartitioningSettings.from_proto(msg.auto_partitioning_settings), | ||
) | ||
|
||
def to_proto(self) -> ydb_topic_pb2.PartitioningSettings: | ||
auto_partitioning_settings = None | ||
if self.auto_partitioning_settings is not None: | ||
auto_partitioning_settings = self.auto_partitioning_settings.to_proto() | ||
|
||
return ydb_topic_pb2.PartitioningSettings( | ||
min_active_partitions=self.min_active_partitions, | ||
partition_count_limit=self.partition_count_limit, | ||
max_active_partitions=self.max_active_partitions, | ||
auto_partitioning_settings=auto_partitioning_settings, | ||
) | ||
|
||
|
||
class AutoPartitioningStrategy(int, IFromProto, IFromPublic, IToPublic): | ||
UNSPECIFIED = 0 | ||
DISABLED = 1 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What about use grpc constants instead of direct numbers? |
||
SCALE_UP = 2 | ||
SCALE_UP_AND_DOWN = 3 | ||
PAUSED = 4 | ||
|
||
@staticmethod | ||
def from_public( | ||
strategy: Optional[ydb_topic_public_types.PublicAutoPartitioningStrategy], | ||
) -> Optional["AutoPartitioningStrategy"]: | ||
if strategy is None: | ||
return None | ||
|
||
return AutoPartitioningStrategy(strategy) | ||
|
||
@staticmethod | ||
def from_proto(code: Optional[int]) -> Optional["AutoPartitioningStrategy"]: | ||
if code is None: | ||
return None | ||
|
||
return AutoPartitioningStrategy(code) | ||
|
||
def to_public(self) -> ydb_topic_public_types.PublicAutoPartitioningStrategy: | ||
try: | ||
return ydb_topic_public_types.PublicAutoPartitioningStrategy(int(self)) | ||
except KeyError: | ||
return ydb_topic_public_types.PublicAutoPartitioningStrategy.UNSPECIFIED | ||
|
||
|
||
@dataclass | ||
class AutoPartitioningSettings(IToProto, IFromProto, IFromPublic, IToPublic): | ||
strategy: AutoPartitioningStrategy | ||
partition_write_speed: AutoPartitioningWriteSpeedStrategy | ||
|
||
@staticmethod | ||
def from_public( | ||
settings: Optional[ydb_topic_public_types.PublicAutoPartitioningSettings], | ||
) -> Optional[AutoPartitioningSettings]: | ||
if not settings: | ||
return None | ||
|
||
return AutoPartitioningSettings( | ||
strategy=settings.strategy, | ||
partition_write_speed=AutoPartitioningWriteSpeedStrategy( | ||
stabilization_window=settings.stabilization_window, | ||
up_utilization_percent=settings.up_utilization_percent, | ||
down_utilization_percent=settings.down_utilization_percent, | ||
), | ||
) | ||
|
||
@staticmethod | ||
def from_proto(msg: ydb_topic_pb2.AutoPartitioningSettings) -> AutoPartitioningSettings: | ||
if msg is None: | ||
return None | ||
|
||
return AutoPartitioningSettings( | ||
strategy=AutoPartitioningStrategy.from_proto(msg.strategy), | ||
partition_write_speed=AutoPartitioningWriteSpeedStrategy.from_proto(msg.partition_write_speed), | ||
) | ||
|
||
def to_proto(self) -> ydb_topic_pb2.AutoPartitioningSettings: | ||
return ydb_topic_pb2.AutoPartitioningSettings( | ||
strategy=self.strategy, partition_write_speed=self.partition_write_speed.to_proto() | ||
) | ||
|
||
def to_public(self) -> ydb_topic_public_types.PublicAutoPartitioningSettings: | ||
return ydb_topic_public_types.PublicAutoPartitioningSettings( | ||
strategy=self.strategy.to_public(), | ||
stabilization_window=self.partition_write_speed.stabilization_window, | ||
up_utilization_percent=self.partition_write_speed.up_utilization_percent, | ||
down_utilization_percent=self.partition_write_speed.down_utilization_percent, | ||
) | ||
|
||
|
||
@dataclass | ||
class AutoPartitioningWriteSpeedStrategy(IToProto, IFromProto): | ||
stabilization_window: Optional[datetime.timedelta] | ||
up_utilization_percent: Optional[int] | ||
down_utilization_percent: Optional[int] | ||
|
||
def to_proto(self): | ||
return ydb_topic_pb2.AutoPartitioningWriteSpeedStrategy( | ||
stabilization_window=proto_duration_from_timedelta(self.stabilization_window), | ||
up_utilization_percent=self.up_utilization_percent, | ||
down_utilization_percent=self.down_utilization_percent, | ||
) | ||
|
||
@staticmethod | ||
def from_proto( | ||
msg: Optional[ydb_topic_pb2.AutoPartitioningWriteSpeedStrategy], | ||
) -> Optional[AutoPartitioningWriteSpeedStrategy]: | ||
if msg is None: | ||
return None | ||
|
||
return AutoPartitioningWriteSpeedStrategy( | ||
stabilization_window=timedelta_from_proto_duration(msg.stabilization_window), | ||
up_utilization_percent=msg.up_utilization_percent, | ||
down_utilization_percent=msg.down_utilization_percent, | ||
) | ||
|
||
|
||
@dataclass | ||
class AlterPartitioningSettings(IToProto): | ||
set_min_active_partitions: Optional[int] | ||
set_partition_count_limit: Optional[int] | ||
set_max_active_partitions: Optional[int] | ||
alter_auto_partitioning_settings: Optional[AlterAutoPartitioningSettings] | ||
|
||
def to_proto(self) -> ydb_topic_pb2.AlterPartitioningSettings: | ||
alter_auto_partitioning_settings = None | ||
if self.alter_auto_partitioning_settings is not None: | ||
alter_auto_partitioning_settings = self.alter_auto_partitioning_settings.to_proto() | ||
|
||
return ydb_topic_pb2.AlterPartitioningSettings( | ||
set_min_active_partitions=self.set_min_active_partitions, | ||
set_partition_count_limit=self.set_partition_count_limit, | ||
set_max_active_partitions=self.set_max_active_partitions, | ||
alter_auto_partitioning_settings=alter_auto_partitioning_settings, | ||
) | ||
|
||
|
||
@dataclass | ||
class AlterAutoPartitioningSettings(IToProto, IFromPublic): | ||
set_strategy: Optional[AutoPartitioningStrategy] | ||
set_partition_write_speed: Optional[AlterAutoPartitioningWriteSpeedStrategy] | ||
|
||
@staticmethod | ||
def from_public( | ||
settings: Optional[ydb_topic_public_types.PublicAlterAutoPartitioningSettings], | ||
) -> Optional[AlterAutoPartitioningSettings]: | ||
if not settings: | ||
return None | ||
|
||
return AlterAutoPartitioningSettings( | ||
set_strategy=settings.set_strategy, | ||
set_partition_write_speed=AlterAutoPartitioningWriteSpeedStrategy( | ||
set_stabilization_window=settings.set_stabilization_window, | ||
set_up_utilization_percent=settings.set_up_utilization_percent, | ||
set_down_utilization_percent=settings.set_down_utilization_percent, | ||
), | ||
) | ||
|
||
def to_proto(self) -> ydb_topic_pb2.AlterAutoPartitioningSettings: | ||
set_partition_write_speed = None | ||
if self.set_partition_write_speed: | ||
set_partition_write_speed = self.set_partition_write_speed.to_proto() | ||
|
||
return ydb_topic_pb2.AlterAutoPartitioningSettings( | ||
set_strategy=self.set_strategy, | ||
set_partition_write_speed=set_partition_write_speed, | ||
) | ||
|
||
|
||
@dataclass | ||
class AlterAutoPartitioningWriteSpeedStrategy(IToProto): | ||
set_stabilization_window: Optional[datetime.timedelta] | ||
set_up_utilization_percent: Optional[int] | ||
set_down_utilization_percent: Optional[int] | ||
|
||
def to_proto(self) -> ydb_topic_pb2.AlterAutoPartitioningWriteSpeedStrategy: | ||
return ydb_topic_pb2.AlterAutoPartitioningWriteSpeedStrategy( | ||
set_stabilization_window=proto_duration_from_timedelta(self.set_stabilization_window), | ||
set_up_utilization_percent=self.set_up_utilization_percent, | ||
set_down_utilization_percent=self.set_down_utilization_percent, | ||
) | ||
|
||
|
||
|
@@ -993,7 +1183,7 @@ def from_proto(code: Optional[int]) -> Optional["MeteringMode"]: | |
|
||
def to_public(self) -> ydb_topic_public_types.PublicMeteringMode: | ||
try: | ||
ydb_topic_public_types.PublicMeteringMode(int(self)) | ||
return ydb_topic_public_types.PublicMeteringMode(int(self)) | ||
except KeyError: | ||
return ydb_topic_public_types.PublicMeteringMode.UNSPECIFIED | ||
|
||
|
@@ -1012,9 +1202,13 @@ class CreateTopicRequest(IToProto, IFromPublic): | |
metering_mode: "MeteringMode" | ||
|
||
def to_proto(self) -> ydb_topic_pb2.CreateTopicRequest: | ||
partitioning_settings = None | ||
if self.partitioning_settings is not None: | ||
partitioning_settings = self.partitioning_settings.to_proto() | ||
|
||
return ydb_topic_pb2.CreateTopicRequest( | ||
path=self.path, | ||
partitioning_settings=self.partitioning_settings.to_proto(), | ||
partitioning_settings=partitioning_settings, | ||
retention_period=proto_duration_from_timedelta(self.retention_period), | ||
retention_storage_mb=self.retention_storage_mb, | ||
supported_codecs=self.supported_codecs.to_proto(), | ||
|
@@ -1039,11 +1233,17 @@ def from_public(req: ydb_topic_public_types.CreateTopicRequestParams): | |
consumer = ydb_topic_public_types.PublicConsumer(name=consumer) | ||
consumers.append(Consumer.from_public(consumer)) | ||
|
||
auto_partitioning_settings = None | ||
if req.auto_partitioning_settings is not None: | ||
auto_partitioning_settings = AutoPartitioningSettings.from_public(req.auto_partitioning_settings) | ||
|
||
return CreateTopicRequest( | ||
path=req.path, | ||
partitioning_settings=PartitioningSettings( | ||
min_active_partitions=req.min_active_partitions, | ||
partition_count_limit=req.partition_count_limit, | ||
max_active_partitions=req.max_active_partitions, | ||
auto_partitioning_settings=auto_partitioning_settings, | ||
), | ||
retention_period=req.retention_period, | ||
retention_storage_mb=req.retention_storage_mb, | ||
|
@@ -1114,13 +1314,21 @@ def from_public(req: ydb_topic_public_types.AlterTopicRequestParams) -> AlterTop | |
consumer = ydb_topic_public_types.PublicAlterConsumer(name=consumer) | ||
alter_consumers.append(AlterConsumer.from_public(consumer)) | ||
|
||
alter_auto_partitioning_settings = None | ||
if req.alter_auto_partitioning_settings is not None: | ||
alter_auto_partitioning_settings = AlterAutoPartitioningSettings.from_public( | ||
req.alter_auto_partitioning_settings | ||
) | ||
|
||
drop_consumers = req.drop_consumers if req.drop_consumers else [] | ||
|
||
return AlterTopicRequest( | ||
path=req.path, | ||
alter_partitioning_settings=AlterPartitioningSettings( | ||
set_min_active_partitions=req.set_min_active_partitions, | ||
set_partition_count_limit=req.set_partition_count_limit, | ||
set_max_active_partitions=req.set_max_active_partitions, | ||
alter_auto_partitioning_settings=alter_auto_partitioning_settings, | ||
), | ||
add_consumers=add_consumers, | ||
set_retention_period=req.set_retention_period, | ||
|
@@ -1181,6 +1389,8 @@ def to_public(self) -> ydb_topic_public_types.PublicDescribeTopicResult: | |
return ydb_topic_public_types.PublicDescribeTopicResult( | ||
self=scheme._wrap_scheme_entry(self.self_proto), | ||
min_active_partitions=self.partitioning_settings.min_active_partitions, | ||
max_active_partitions=self.partitioning_settings.max_active_partitions, | ||
auto_partitioning_settings=self.partitioning_settings.auto_partitioning_settings.to_public(), | ||
partition_count_limit=self.partitioning_settings.partition_count_limit, | ||
partitions=list(map(DescribeTopicResult.PartitionInfo.to_public, self.partitions)), | ||
retention_period=self.retention_period, | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.