Skip to content

Add docstrings about experimental API #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions ydb/query/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@ def __init__(self, driver: SupportedDriverType, settings: Optional[QueryClientSe

@abc.abstractmethod
def create(self) -> "IQuerySession":
"""
"""WARNING: This API is experimental and could be changed.

Creates a Session of Query Service on server side and attaches it.

:return: Session object.
Expand All @@ -112,7 +113,8 @@ def create(self) -> "IQuerySession":

@abc.abstractmethod
def delete(self) -> None:
"""
"""WARNING: This API is experimental and could be changed.

Deletes a Session of Query Service on server side and releases resources.

:return: None
Expand All @@ -121,7 +123,8 @@ def delete(self) -> None:

@abc.abstractmethod
def transaction(self, tx_mode: Optional[BaseQueryTxMode] = None) -> "IQueryTxContext":
"""
"""WARNING: This API is experimental and could be changed.

Creates a transaction context manager with specified transaction mode.

:param tx_mode: Transaction mode, which is a one from the following choises:
Expand All @@ -143,7 +146,8 @@ def execute(
parameters: Optional[dict] = None,
concurrent_result_sets: Optional[bool] = False,
) -> Iterator:
"""
"""WARNING: This API is experimental and could be changed.

Sends a query to Query Service
:param query: (YQL or SQL text) to be executed.
:param syntax: Syntax of the query, which is a one from the following choises:
Expand Down Expand Up @@ -235,7 +239,8 @@ def tx_id(self) -> Optional[str]:

@abc.abstractmethod
def begin(self, settings: Optional[QueryClientSettings] = None) -> None:
"""
"""WARNING: This API is experimental and could be changed.

Explicitly begins a transaction

:param settings: A request settings
Expand All @@ -246,7 +251,8 @@ def begin(self, settings: Optional[QueryClientSettings] = None) -> None:

@abc.abstractmethod
def commit(self, settings: Optional[QueryClientSettings] = None) -> None:
"""
"""WARNING: This API is experimental and could be changed.

Calls commit on a transaction if it is open. If transaction execution
failed then this method raises PreconditionFailed.

Expand All @@ -258,7 +264,8 @@ def commit(self, settings: Optional[QueryClientSettings] = None) -> None:

@abc.abstractmethod
def rollback(self, settings: Optional[QueryClientSettings] = None) -> None:
"""
"""WARNING: This API is experimental and could be changed.

Calls rollback on a transaction if it is open. If transaction execution
failed then this method raises PreconditionFailed.

Expand All @@ -278,7 +285,8 @@ def execute(
parameters: Optional[dict] = None,
concurrent_result_sets: Optional[bool] = False,
) -> Iterator:
"""
"""WARNING: This API is experimental and could be changed.

Sends a query to Query Service
:param query: (YQL or SQL text) to be executed.
:param commit_tx: A special flag that allows transaction commit.
Expand Down
10 changes: 7 additions & 3 deletions ydb/query/pool.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,15 @@ def __init__(self, driver: base.SupportedDriverType):
self._driver = driver

def checkout(self) -> "SimpleQuerySessionCheckout":
"""Return a Session context manager, that opens session on enter and closes session on exit."""
"""WARNING: This API is experimental and could be changed.
Return a Session context manager, that opens session on enter and closes session on exit.
"""

return SimpleQuerySessionCheckout(self)

def retry_operation_sync(self, callee: Callable, retry_settings: Optional[RetrySettings] = None, *args, **kwargs):
"""Special interface to execute a bunch of commands with session in a safe, retriable way.
"""WARNING: This API is experimental and could be changed.
Special interface to execute a bunch of commands with session in a safe, retriable way.

:param callee: A function, that works with session.
:param retry_settings: RetrySettings object.
Expand All @@ -54,7 +57,8 @@ def wrapped_callee():
def execute_with_retries(
self, query: str, retry_settings: Optional[RetrySettings] = None, *args, **kwargs
) -> List[convert.ResultSet]:
"""Special interface to execute a one-shot queries in a safe, retriable way.
"""WARNING: This API is experimental and could be changed.
Special interface to execute a one-shot queries in a safe, retriable way.
Note: this method loads all data from stream before return, do not use this
method with huge read queries.

Expand Down
12 changes: 8 additions & 4 deletions ydb/query/session.py
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,8 @@ def _check_session_status_loop(self, status_stream: _utilities.SyncResponseItera
pass

def delete(self) -> None:
"""
"""WARNING: This API is experimental and could be changed.

Deletes a Session of Query Service on server side and releases resources.

:return: None
Expand All @@ -240,7 +241,8 @@ def delete(self) -> None:
self._stream.cancel()

def create(self) -> "QuerySessionSync":
"""
"""WARNING: This API is experimental and could be changed.

Creates a Session of Query Service on server side and attaches it.

:return: QuerySessionSync object.
Expand All @@ -255,7 +257,8 @@ def create(self) -> "QuerySessionSync":
return self

def transaction(self, tx_mode: Optional[base.BaseQueryTxMode] = None) -> base.IQueryTxContext:
"""
"""WARNING: This API is experimental and could be changed.

Creates a transaction context manager with specified transaction mode.
:param tx_mode: Transaction mode, which is a one from the following choises:
1) QuerySerializableReadWrite() which is default mode;
Expand Down Expand Up @@ -285,7 +288,8 @@ def execute(
parameters: dict = None,
concurrent_result_sets: bool = False,
) -> base.SyncResponseContextIterator:
"""
"""WARNING: This API is experimental and could be changed.

Sends a query to Query Service
:param query: (YQL or SQL text) to be executed.
:param syntax: Syntax of the query, which is a one from the following choises:
Expand Down
25 changes: 22 additions & 3 deletions ydb/query/transaction.py
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,8 @@ def _move_to_commited(self) -> None:
self._tx_state._change_state(QueryTxStateEnum.COMMITTED)

def begin(self, settings: Optional[base.QueryClientSettings] = None) -> None:
"""
"""WARNING: This API is experimental and could be changed.

Explicitly begins a transaction

:param settings: A request settings
Expand All @@ -326,7 +327,8 @@ def begin(self, settings: Optional[base.QueryClientSettings] = None) -> None:
self._begin_call(settings)

def commit(self, settings: Optional[base.QueryClientSettings] = None) -> None:
"""
"""WARNING: This API is experimental and could be changed.

Calls commit on a transaction if it is open otherwise is no-op. If transaction execution
failed then this method raises PreconditionFailed.

Expand Down Expand Up @@ -369,7 +371,24 @@ def execute(
parameters: Optional[dict] = None,
concurrent_result_sets: Optional[bool] = False,
) -> base.SyncResponseContextIterator:

"""WARNING: This API is experimental and could be changed.

Sends a query to Query Service
:param query: (YQL or SQL text) to be executed.
:param commit_tx: A special flag that allows transaction commit.
:param syntax: Syntax of the query, which is a one from the following choises:
1) QuerySyntax.YQL_V1, which is default;
2) QuerySyntax.PG.
:param exec_mode: Exec mode of the query, which is a one from the following choises:
1) QueryExecMode.EXECUTE, which is default;
2) QueryExecMode.EXPLAIN;
3) QueryExecMode.VALIDATE;
4) QueryExecMode.PARSE.
:param parameters: dict with parameters and YDB types;
:param concurrent_result_sets: A flag to allow YDB mix parts of different result sets. Default is False;

:return: Iterator with result sets
"""
self._ensure_prev_stream_finished()
self._tx_state._check_tx_ready_to_use()

Expand Down
Loading