Skip to content

Fix stream_reader.close() call #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2024
Merged

Fix stream_reader.close() call #445

merged 1 commit into from
Jun 25, 2024

Conversation

nklokk
Copy link
Contributor

@nklokk nklokk commented Jun 25, 2024 •
edited
Loading

Fix: ReaderStream.close() missing 1 required positional argument: 'flush'

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #440

What is the new behavior?

Other information

@nklokk nklokk changed the title Fix stream_reader close Fix stream_reader.close() call Jun 25, 2024
@rekby rekby merged commit 0cf6722 into ydb-platform:main Jun 25, 2024
9 checks passed
@rekby
Copy link
Member

rekby commented Jun 25, 2024

Thanks for the fix :)

@nklokk nklokk deleted the fix_stream_reader_close branch June 25, 2024 14:34
@nklokk nklokk mentioned this pull request Jun 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rekby rekby rekby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nklokk @rekby