-
Notifications
You must be signed in to change notification settings - Fork 19
YDBOPS-9613 conditions for NodeSet objects #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artgromov
approved these changes
May 13, 2024
artgromov
approved these changes
May 13, 2024
kobzonega
added a commit
that referenced
this pull request
May 13, 2024
kobzonega
added a commit
to kobzonega/ydb-kubernetes-operator
that referenced
this pull request
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Problem of unavailability some hosts at the time of cluster creation. Storage/Database object moved to "Ready" status only when all NodeSet provisioned and Ready. We should be able not to wait for all hosts to start and only check the creation and preparing of all necessary objects.
Issue Number: YDBOPS-9613
What is the new behavior?
DatabaseNodeSetPreparing
andStorageNodeSetPreparing
to determinehandleResourceSync
step first runningNodeSetPreparedCondition
to determine that all child resources createdNodeSetProvisionedCondition
to determine that all pods are created and havestatus.phase=="Running"
NodeSetReadyCondition
to determine that all conditions are True and last Reconcile successfully moved toReady
statusNodeSetPausedCondition
to determine that all conditions are True and last Reconcile successfully moved toPaused
status.status.state
on step first runOther information
.spec.operatorSync
tohandleResourcesSync
step