Skip to content

YDBOPS-9613 conditions for NodeSet objects #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
May 13, 2024
Merged

YDBOPS-9613 conditions for NodeSet objects #197

merged 20 commits into from
May 13, 2024

Conversation

kobzonega
Copy link
Contributor

@kobzonega kobzonega commented Apr 27, 2024

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Problem of unavailability some hosts at the time of cluster creation. Storage/Database object moved to "Ready" status only when all NodeSet provisioned and Ready. We should be able not to wait for all hosts to start and only check the creation and preparing of all necessary objects.

Issue Number: YDBOPS-9613

What is the new behavior?

  • Status.state DatabaseNodeSetPreparing and StorageNodeSetPreparing to determine handleResourceSync step first running
  • New conditions for NodeSet* objects:
    • NodeSetPreparedCondition to determine that all child resources created
    • NodeSetProvisionedCondition to determine that all pods are created and have status.phase=="Running"
    • NodeSetReadyCondition to determine that all conditions are True and last Reconcile successfully moved to Ready status
    • NodeSetPausedCondition to determine that all conditions are True and last Reconcile successfully moved to Paused status
  • Set "Unknown" status for condition and change value of .status.state on step first run
  • Set "False" status for condition if non-Kubernetes error inside current Reconcile run
  • Set "True" status for condition if non-True status was set previously

Other information

  • Move handler for .spec.operatorSync to handleResourcesSync step

@kobzonega kobzonega changed the title conditions for NodeSet objects YDBOPS-9613 conditions for NodeSet objects May 8, 2024
@kobzonega kobzonega self-assigned this May 8, 2024
@kobzonega kobzonega requested a review from artgromov May 8, 2024 11:59
@artgromov artgromov added the ok-to-test Testing pipelines will run label May 13, 2024
@github-actions github-actions bot removed the ok-to-test Testing pipelines will run label May 13, 2024
@artgromov artgromov added the ok-to-test Testing pipelines will run label May 13, 2024
@github-actions github-actions bot removed the ok-to-test Testing pipelines will run label May 13, 2024
@kobzonega kobzonega merged commit 55d84a6 into master May 13, 2024
19 of 21 checks passed
@kobzonega kobzonega deleted the YDBOPS-9613 branch May 13, 2024 14:39
kobzonega added a commit to kobzonega/ydb-kubernetes-operator that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants