fix: remove keybindings for history traversing #2611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bugbot run |
There was a problem hiding this comment.
Pull Request Overview
This PR removes keyboard shortcut bindings for history traversing functionality (previous/next query navigation) to address issue #2610. The changes systematically remove the keybinding definitions, their usage in editor actions, and the corresponding UI documentation.
Key changes:
- Removed keybinding definitions for
selectPreviousQueryandselectNextQueryactions - Removed keyboard shortcuts from Monaco editor actions while preserving context menu functionality
- Cleaned up related internationalization strings and hotkey panel documentation
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/containers/Tenant/Query/QueryEditor/keybindings.ts |
Removed keybinding definitions for previous/next query navigation |
src/containers/Tenant/Query/QueryEditor/YqlEditor.tsx |
Removed keyboard shortcuts from Monaco editor actions |
src/containers/AsideNavigation/i18n/ru.json |
Removed Russian translations for history navigation hotkeys |
src/containers/AsideNavigation/i18n/en.json |
Removed English translations for history navigation hotkeys |
src/containers/AsideNavigation/hooks/useHotkeysPanel.tsx |
Removed hotkey documentation entries from the help panel |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no bugs!
Bugbot free trial expires on July 29, 2025
Learn more in the Cursor dashboard.
Was this report helpful? Give feedback by reacting with 👍 or 👎
astandrik
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2610
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ⏭️2
⏭️ Skipped Tests (2)
Bundle Size: ✅
Current: 85.21 MB | Main: 85.21 MB
Diff: 1.15 KB (-0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information